Skip to content

Reduce closure allocations in TokenizerBackedParser.ConfigureSpanContext #12238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2025
Merged

Reduce closure allocations in TokenizerBackedParser.ConfigureSpanContext #12238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0e3651
*** WIP: Reduce closure allocations in TokenizerBackedParser.Configur…
ToddGrun Sep 16, 2025
93b5079
Keep the local, add a comment
ToddGrun Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...mpiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Legacy/TokenizerBackedParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,8 +708,14 @@ protected void ConfigureSpanContext(SpanContextConfigActionWithPreviousConfig? c
var prev = SpanContextConfig;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this line be kept? It seems a bit harder to read when SpanContextConfig is set to an expression that uses the previous value of SpanContentConfig?

SpanContextConfig = config == null
? null
: ((SpanEditHandlerBuilder? span, ref ISpanChunkGenerator? chunkGenerator) => config(span, ref chunkGenerator, prev));
: GetNewSpanContextConfigAction(config, prev);
InitializeContext();

// Separated into it's own method to avoid closure allocations when not being called
static SpanContextConfigAction GetNewSpanContextConfigAction(SpanContextConfigActionWithPreviousConfig config, SpanContextConfigAction? prev)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is uncommon enough that it I think it probably warrants a comment that it needed to avoid allocations.

{
return (span, ref chunkGenerator) => config(span, ref chunkGenerator, prev);
}
}

protected void InitializeContext()
Expand Down