Reduce closure allocations in TokenizerBackedParser.ConfigureSpanContext #12238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eSpanContext Move the closure allocation to it's own method which should slightly reduce allocations when there isn't an existing SpanContextConfig. Will do a speedometer run with this change to make sure it effects things the way I think it does.
There was a problem hiding this comment.
Move the closure allocation to it's own method which should slightly reduce allocations when there isn't an existing SpanContextConfig.
I must be missing something here. Instead of creating a closure directly, the code now calls a method that creates a closure. I'm not seeing any new conditions where the closure would be created less often.
| : GetNewSpanContextConfigAction(config, SpanContextConfig); | ||
| InitializeContext(); | ||
|
|
||
| static SpanContextConfigAction GetNewSpanContextConfigAction(SpanContextConfigActionWithPreviousConfig config, SpanContextConfigAction? prev) |
There was a problem hiding this comment.
This is uncommon enough that it I think it probably warrants a comment that it needed to avoid allocations.
|
|
||
| protected void ConfigureSpanContext(SpanContextConfigActionWithPreviousConfig? config) | ||
| { | ||
| var prev = SpanContextConfig; |
There was a problem hiding this comment.
Can this line be kept? It seems a bit harder to read when SpanContextConfig is set to an expression that uses the previous value of SpanContentConfig?
DustinCampbell
approved these changes
Sep 17, 2025
This was referenced Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce closure allocations in TokenizerBackedParser.ConfigureSpanContext
Move the closure allocation to it's own method which should slightly reduce allocations when there isn't an existing SpanContextConfig.
Speeedometer run failed for some reason and I don't want to wait another 8 hours to get verify what I'm pretty confident in already.
Test insertion pipeline run (failed): https://dev.azure.com/dnceng/internal/_build/results?buildId=2795099&view=results