Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Fix dotnet-runtime-perf build for wasm #2542

Merged
merged 2 commits into from
Aug 1, 2022
Merged

[wasm] Fix dotnet-runtime-perf build for wasm #2542

merged 2 commits into from
Aug 1, 2022

Commits on Jul 30, 2022

  1. Fix build error with new runtime 

    The wasm builds on `dotnet-runtime-perf` started breaking after `Fix
UnsupportedOSPlatformAttribute usage in
System.Net.NetworkInformation.cs`
(dotnet/runtime#72792) was merged, with:

```
error CA1416: This call site is reachable on all platforms. 'IPInterfaceStatistics.IncomingUnknownProtocolPackets' is unsupported on: 'linux'. [/home/helixbot/work/AFE009B6/w/B4280986/e/performance/src/benchmarks/micro/MicroBenchmarks.csproj::TargetFramework=net7.0]
error CA1416: This call site is reachable on all platforms. 'IPInterfaceProperties.IsDynamicDnsEnabled' is supported on: 'windows'. [/home/helixbot/work/AFE009B6/w/B4280986/e/performance/src/benchmarks/micro/MicroBenchmarks.csproj::TargetFramework=net7.0]
error CA1416: This call site is reachable on all platforms. 'IPInterfaceStatistics.NonUnicastPacketsSent' is unsupported on: 'linux'. [/home/helixbot/work/AFE009B6/w/B4280986/e/performance/src/benchmarks/micro/MicroBenchmarks.csproj::TargetFramework=net7.0]
error CA1416: This call site is reachable on all platforms. 'IPInterfaceProperties.AnycastAddresses' is supported on: 'windows'. [/home/helixbot/work/AFE009B6/w/B4280986/e/performance/src/benchmarks/micro/MicroBenchmarks.csproj::TargetFramework=net7.0]
```

This commit adds guards around these calls.
    @radical
    radical committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    875b349 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. fix Full Framework build

    @adamsitnik
    adamsitnik authored Aug 1, 2022
    Configuration menu
    Copy the full SHA
    0fa23b9 View commit details
    Browse the repository at this point in the history