[wasm] Fix dotnet-runtime-perf build for wasm
#2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wasm builds on `dotnet-runtime-perf` started breaking after `Fix UnsupportedOSPlatformAttribute usage in System.Net.NetworkInformation.cs` (dotnet/runtime#72792) was merged, with: ``` error CA1416: This call site is reachable on all platforms. 'IPInterfaceStatistics.IncomingUnknownProtocolPackets' is unsupported on: 'linux'. [/home/helixbot/work/AFE009B6/w/B4280986/e/performance/src/benchmarks/micro/MicroBenchmarks.csproj::TargetFramework=net7.0] error CA1416: This call site is reachable on all platforms. 'IPInterfaceProperties.IsDynamicDnsEnabled' is supported on: 'windows'. [/home/helixbot/work/AFE009B6/w/B4280986/e/performance/src/benchmarks/micro/MicroBenchmarks.csproj::TargetFramework=net7.0] error CA1416: This call site is reachable on all platforms. 'IPInterfaceStatistics.NonUnicastPacketsSent' is unsupported on: 'linux'. [/home/helixbot/work/AFE009B6/w/B4280986/e/performance/src/benchmarks/micro/MicroBenchmarks.csproj::TargetFramework=net7.0] error CA1416: This call site is reachable on all platforms. 'IPInterfaceProperties.AnycastAddresses' is supported on: 'windows'. [/home/helixbot/work/AFE009B6/w/B4280986/e/performance/src/benchmarks/micro/MicroBenchmarks.csproj::TargetFramework=net7.0] ``` This commit adds guards around these calls.
adamsitnik
approved these changes
Aug 1, 2022
adamsitnik
reviewed
Aug 1, 2022
src/benchmarks/micro/libraries/System.Net.NetworkInformation/NetworkInterfaceTests.cs
Show resolved
Hide resolved
src/benchmarks/micro/libraries/System.Net.NetworkInformation/NetworkInterfaceTests.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wasm builds on
dotnet-runtime-perfstarted breaking afterFix UnsupportedOSPlatformAttribute usage in System.Net.NetworkInformation.cs(dotnet/runtime#72792) was merged, with:
This commit adds guards around these calls.