Skip to content

Resource for invalid -tl value #9078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2023
Merged

Resource for invalid -tl value #9078

merged 1 commit into from
Jul 29, 2023

Conversation

@rainersigwald
Copy link
Member

@rainersigwald rainersigwald commented Jul 27, 2023

When passed an invalid value, like "off", we were crashing instead of emitting an
error, because the resource hadn't been created.

$ .dotnet/dotnet ./artifacts/bin/MSBuild.Bootstrap/Debug/net8.0/MSBuild.dll -tl:off
MSBuild version 17.8.0-dev-23377-01+fd4d0e5ca for .NET
MSBUILD : error MSB1065: Terminal logger value is not valid. It should be one of 'auto', 'true', or 'false'. 
Switch: off

@rainersigwald
Resource for invalid -tl value
38888fb 
When passed an invalid value, like "off", we were crashing instead of emitting an
error, because the resource hadn't been created.
baronfel
baronfel approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rainersigwald rainersigwald enabled auto-merge (squash) July 27, 2023 21:00
@rainersigwald rainersigwald added the Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. label Jul 27, 2023
@rainersigwald rainersigwald merged commit e2e438e into main Jul 29, 2023
@rainersigwald rainersigwald deleted the rename-tl-resource branch July 29, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baronfel baronfel baronfel approved these changes

+1 more reviewer

@JanKrivanek JanKrivanek JanKrivanek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rainersigwald @baronfel @JanKrivanek