Skip to content

Commit e2e438e

Browse files
Resource for invalid -tl value (#9078)
When passed an invalid value, like "off", we were crashing instead of emitting an error, because the resource hadn't been created.
1 parent edeacbb commit e2e438e

File tree

14 files changed

+140
-1
lines changed

14 files changed

+140
-1
lines changed

src/MSBuild/Resources/Strings.resx

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1244,6 +1244,15 @@
12441244
LOCALIZATION: The prefix "MSBUILD : error MSBxxxx:" should not be localized.
12451245
</comment>
12461246
</data>
1247+
<data name="InvalidTerminalLoggerValue" UESanitized="true" Visibility="Public">
1248+
<value>MSBUILD : error MSB1065: Terminal logger value is not valid. It should be one of 'auto', 'true', or 'false'. {0}</value>
1249+
<comment>
1250+
{StrBegin="MSBUILD : error MSB1065: "}
1251+
UE: This message does not need in-line parameters because the exception takes care of displaying the invalid arg.
1252+
This error is shown when a user specifies a value for the lowPriority parameter that is not equivalent to Boolean.TrueString or Boolean.FalseString.
1253+
LOCALIZATION: The prefix "MSBUILD : error MSBxxxx:" should not be localized.
1254+
</comment>
1255+
</data>
12471256
<data name="AbortingBuild" UESanitized="true" Visibility="Public">
12481257
<value>Attempting to cancel the build...</value>
12491258
</data>
@@ -1500,7 +1509,7 @@
15001509
<!--
15011510
The command line message bucket is: MSB1001 - MSB1999
15021511
1503-
Next error code should be MSB1065.
1512+
Next error code should be MSB1066.
15041513
15051514
Don't forget to update this comment after using the new code.
15061515
-->

src/MSBuild/Resources/xlf/Strings.cs.xlf

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/MSBuild/Resources/xlf/Strings.de.xlf

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/MSBuild/Resources/xlf/Strings.es.xlf

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/MSBuild/Resources/xlf/Strings.fr.xlf

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/MSBuild/Resources/xlf/Strings.it.xlf

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/MSBuild/Resources/xlf/Strings.ja.xlf

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/MSBuild/Resources/xlf/Strings.ko.xlf

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/MSBuild/Resources/xlf/Strings.pl.xlf

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/MSBuild/Resources/xlf/Strings.pt-BR.xlf

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)