[vs17.14] Add test summary always in terminal logger #12852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanProvaznik
approved these changes
Dec 1, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI issue in the Terminal Logger where test summaries were inconsistently reported due to null node references. The fix ensures that test finish messages (which contain summary statistics) are always processed, even when the terminal node status is null.
Key changes:
- Modified null-check pattern to allow
TLTESTFINISHmessages to be processed regardless of node status - Added explicit null checks for
TLTESTPASSEDandTLTESTSKIPPEDcases that actually use the node variable
Member
Author
|
@JanProvaznik was approved, please merge. |
ViktorHofer
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running tests with dotnet test, users see inconsistent number of projects and tests reported in the view. This is a UI only issue, failing tests will still fail the build. It is still worth fixing the issue because it makes the runs show repeatable numbers of tests to the user.
The terminal node can be null before we receive the finish message. This will cause that some summaries are not accounted for and will be missing in the final output.
The node is null for this reason: #12819 That fix is not backported.
Customer Impact: Multiple runs of the same test suite report different total counts of tests and projects.
Regression? No, this was never working correctly since the beginning of test reporting in Terminal Logger.
Risk: Low, it impacts UI only.
Link the PR to the original issue and to the PR to main.
PR to main is merged: #12801
Fixes microsoft/vstest#15307
No additional impact on packages or localization.