Add test summary always in terminal logger #12801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where test run summaries were missing from the terminal logger output when the terminal node becomes null before receiving the test finish message. The fix ensures that test summary messages (TLTESTFINISH) are processed even when the active node is unavailable, while still protecting node-dependent operations (TLTESTPASSED/TLTESTSKIPPED) with explicit null checks.
Key Changes
- Removed the
node != nullcondition from the outer check, allowing all test-related extended messages to be processed regardless of node state - Added explicit nullable type annotation to the node variable for clarity
- Added null checks specifically for TLTESTPASSED and TLTESTSKIPPED cases that require the node to update status
- Removed trailing whitespace for code cleanliness
Youssef1313
reviewed
Nov 21, 2025
Youssef1313
approved these changes
Nov 21, 2025
Youssef1313
reviewed
Nov 21, 2025
AR-May
approved these changes
Nov 21, 2025
JanProvaznik
approved these changes
Nov 21, 2025
Member
JanProvaznik
left a comment
JanProvaznik
left a comment
There was a problem hiding this comment.
makes sense to decouple
regarding when the node is null, copilot had an interesting hypothesis that it might be due to state not being restored after returning from MSBuild task
This was referenced Nov 22, 2025
Member
|
/backport to vs17.14 |
Contributor
|
Started backporting to |
Contributor
|
@JanProvaznik backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Add test summary always in terminal logger
Using index info to reconstruct a base tree...
M src/Build/Logging/TerminalLogger/TerminalLogger.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Build/Logging/TerminalLogger/TerminalLogger.cs
CONFLICT (content): Merge conflict in src/Build/Logging/TerminalLogger/TerminalLogger.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add test summary always in terminal logger
Error: The process '/usr/bin/git' failed with exit code 128 |
ViktorHofer
pushed a commit
that referenced
this pull request
Dec 4, 2025
**Description** Running tests with dotnet test, users see inconsistent number of projects and tests reported in the view. This is a UI only issue, failing tests will still fail the build. It is still worth fixing the issue because it makes the runs show repeatable numbers of tests to the user. The terminal node can be null before we receive the finish message. This will cause that some summaries are not accounted for and will be missing in the final output. The node is null for this reason: #12819 That fix is not backported. **Customer Impact:** Multiple runs of the same test suite report different total counts of tests and projects. **Regression?** No, this was never working correctly since the beginning of test reporting in Terminal Logger. **Risk:** Low, it impacts UI only. Link the PR to the original issue and to the PR to main. PR to main is merged: #12801 Fixes microsoft/vstest#15307 No additional impact on packages or localization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vstest#15307
Context
The terminal node can be null before we receive the finish message. This will cause that some summaries are not accounted for and will be missing in the final output.
Changes Made
Always update data for messages that don't require active node.
Testing
Tested manually on local build of msbuild.
I was not able to trace why the node becomes null, please help.
Notes