Revert "Include resources in command line arguments produced by csc in design-time build" #11946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n design…" This reverts commit e2e12b5.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Reverts the prior change that injected resource outputs into the design-time build’s compiler arguments, restoring the previous resource handling to avoid VMR breakage.
- Removes the
AssignEmbeddedResourceOutputPathstarget and its dependency declaration. - Inlines the resource output path in
OutputResourcesinstead of using the removed metadata. - Drops the
PrepareResourceNamesdependency from the_GenerateCompileInputstarget.
Comments suppressed due to low confidence (1)
src/Tasks/Microsoft.Common.CurrentVersion.targets:3667
- Removing the DependsOnTargets="PrepareResourceNames" may cause this target to run before resource names are computed, potentially leading to incorrect compile inputs. Consider restoring the dependency or ensuring PrepareResourceNames runs first.
<Target Name="_GenerateCompileInputs">
JanProvaznik
approved these changes
Jun 3, 2025
surayya-MS
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11893 because it causes issues in VMR dotnet/dotnet#918 (comment)