Include resources in command line arguments produced by csc in design-time build #11893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to include embedded resource information in the command line arguments produced by csc during design-time builds to support resource updates during Hot Reload.
- Introduces a new target, AssignEmbeddedResourceOutputPaths, to assign OutputResource metadata for EmbeddedResource items.
- Updates the PrepareResourceNames dependency chain and modifies the _GenerateCompileInputs target to include PrepareResourceNames, ensuring resources are processed.
- Adjusts the OutputResources property to utilize the new OutputResource metadata.
Comments suppressed due to low confidence (1)
src/Tasks/Microsoft.Common.CurrentVersion.targets:3268
- Consider adding automated tests to verify that the OutputResource metadata is correctly assigned for EmbeddedResource items during design-time builds.
<Target Name="AssignEmbeddedResourceOutputPaths">
This was referenced May 25, 2025
rainersigwald
approved these changes
May 27, 2025
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
YuliiaKovalova
approved these changes
Jun 2, 2025
Member
|
This PR causes issue in the other repo, I am reverting it to unblock VMR |
Member
Author
|
I found the problem. Working on a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
csctask in design-time build does not currently get the list of embedded resources as an input and thus does not include them in the generated command line.Target
_GenerateCompileInputsthat generates the inputs needsEmbeddedResourceto have metadataWithCulture,TypeandOutputResourceset. The former two are set inSplitResourcesByCulturetarget, which is a dependency ofPrepareResourceNamestarget. TheOutputResourceis currently set byGenerateResourcetask.To support updating resources during Hot Reload Roslyn needs to track resource files. To do that
/resourcecommand line arguments need to be produced bycsctask at design-time.Changes Made
This change moves setting of
OutputResourcemetadata to a new targetAssignEmbeddedResourceOutputPathsthat is a dependency ofPrepareResourceNames.The change also includes
PrepareResourceNamesin the dependencies of_GenerateCompileInputstarget, so that it is run during design-time build.Testing
Manual testing of DTB with this change.
Notes