Fix set the Font to Microsoft.Maui.Graphics.Skia #9124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mattleibow
approved these changes
Aug 2, 2022
Eilon
added
the
area-drawing
jfversluis
approved these changes
Aug 4, 2022
Member
Author
|
Thank you @matleibow and @jfversluis |
Member
|
Thank you so much for your contribution @lindexi ! |
|
But don't forget to review the same pr in SkiaSharp.@mattleibow |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When the
_fontis null that it will never set the value to the_fontfield.It always return false when the
_fontis null:This bug is a cause of dotnet/Microsoft.Maui.Graphics#473 . We can not set any Font name to SkiaCanvas and the default Font do not support Chinese text.
The origin PR: dotnet/Microsoft.Maui.Graphics#474
Issues Fixed
Fixes #dotnet/Microsoft.Maui.Graphics#473