This repository was archived by the owner on Dec 21, 2023. It is now read-only.
Fix set the Font to Microsoft.Maui.Graphics.Skia #474
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `_font` is null that it will never set the value to the `_font` field. It always return false when the `_font` is null: ``` _font != value && _font != null ```
jsuarezruiz
approved these changes
Jul 22, 2022
Member
Author
|
Thank you. @jsuarezruiz |
Member
|
@lindexi Thanks for this PR. We just merged dotnet/maui#8739 and was wondering if you were interested in recreating this PR in the main maui repo? We are going to be moving the issues there soon as well, so you don't need to do that. |
Member
Author
|
@mattleibow Thank you. And I will recreate it. |
Member
Author
|
@mattleibow Thank you and I recreated this in dotnet/maui#9124 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
_fontis null that it will never set the value to the_fontfield.It always return false when the
_fontis null:This bug is a cause of #473 . We can not set any Font name to SkiaCanvas and the default Font do not support Chinese text.