-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Android, Windows] Fix for FlyoutPage toolbar button not updating on orientation change #31962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
praveenkumarkarunanithi
wants to merge
3
commits into
dotnet:main
Choose a base branch
from
praveenkumarkarunanithi:fix-24468
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+107
−0
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
namespace Maui.Controls.Sample.Issues; | ||
|
||
[Issue(IssueTracker.Github, 24468, "FlyoutPage toolbar button not updating on orientation change on Android", | ||
PlatformAffected.Android)] | ||
public class Issue24468 : TestFlyoutPage | ||
{ | ||
private Label _statusLabel; | ||
private int _callCount = 0; | ||
|
||
protected override void Init() | ||
{ | ||
Title = "Issue 24468"; | ||
|
||
_statusLabel = new Label | ||
{ | ||
Text = "ShouldShowToolbarButton is not called", | ||
AutomationId = "StatusLabel" | ||
}; | ||
|
||
Flyout = new ContentPage | ||
{ | ||
Title = "Menu", | ||
Content = new Label { Text = "Flyout Menu" } | ||
}; | ||
|
||
Detail = new NavigationPage(new ContentPage | ||
{ | ||
Title = "Detail", | ||
Content = new StackLayout | ||
{ | ||
Children = | ||
{ | ||
new Label { Text = "Rotate device to test toolbar button updates" }, | ||
_statusLabel | ||
} | ||
}, | ||
AutomationId = "ContentPage" | ||
}); | ||
|
||
FlyoutLayoutBehavior = FlyoutLayoutBehavior.SplitOnLandscape; | ||
} | ||
|
||
public override bool ShouldShowToolbarButton() | ||
{ | ||
_callCount++; | ||
var shouldShow = base.ShouldShowToolbarButton(); | ||
|
||
if (_callCount > 1) | ||
{ | ||
_statusLabel.Text = "ShouldShowToolbarButton is called"; | ||
} | ||
|
||
return shouldShow; | ||
} | ||
} |
25 changes: 25 additions & 0 deletions
25
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24468.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
#if ANDROID || IOS //The test fails on Windows and MacCatalyst because the SetOrientation method, which is intended to change the device orientation, is only supported on mobile platforms iOS and Android. | ||
using UITest.Core; | ||
|
||
namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
public class Issue24468 : _IssuesUITest | ||
{ | ||
public Issue24468(TestDevice device) : base(device) | ||
{ | ||
} | ||
|
||
public override string Issue => "FlyoutPage toolbar button not updating on orientation change on Android"; | ||
[Test] | ||
[Category(UITestCategories.Navigation)] | ||
public void FlyoutPageToolbarButtonUpdatesOnOrientationChange() | ||
{ | ||
App.WaitForElement("ContentPage"); | ||
|
||
App.SetOrientationLandscape(); | ||
|
||
var text = App.FindElement("StatusLabel").GetText(); | ||
Assert.That(text, Contains.Substring("ShouldShowToolbarButton is called")); | ||
App.SetOrientationPortrait(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can use |
||
} | ||
} | ||
#endif |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is re-evaluated on iOS? Why is not required in that case?