[Android, Windows] Fix for FlyoutPage toolbar button not updating on orientation change #31962
+107
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@praveenkumarkarunanithi! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
jsuarezruiz
reviewed
Oct 10, 2025
| #if ANDROID || WINDOWS | ||
| void OnOrientationChanged(object sender, Microsoft.Maui.Devices.DisplayInfoChangedEventArgs e) | ||
| { | ||
| // Re-evaluate toolbar button visibility when orientation changes |
There was a problem hiding this comment.
Where is re-evaluated on iOS? Why is not required in that case?
|
|
||
| var text = App.FindElement("StatusLabel").GetText(); | ||
| Assert.That(text, Contains.Substring("ShouldShowToolbarButton is called")); | ||
| App.SetOrientationPortrait(); |
There was a problem hiding this comment.
Can use try-finally to always restore the state even if there is any error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
On Android and Windows, the
FlyoutPagetoolbar button did not update correctly when the device orientation changed. TheNavigationPageToolbarlacked orientation change detection, soShouldShowToolbarButton()was never re-evaluated after rotation.Description of Change
Added orientation change handling in
NavigationPageToolbarfor Android and Windows by subscribing toDeviceDisplay.MainDisplayInfoChanged. On rotation, the toolbar button visibility is re-evaluated by callingApplyChanges, which internally checksShouldShowToolbarButton(). The subscription is cleaned up on disconnect to prevent leaks. This ensures the toolbar button updates correctly across orientation changes while following MAUI’s existing patterns for cross-platform event handling.Issues Fixed
Fixes #24468
Tested the behaviour in the following platforms
Note:
The fix was implemented and tested on Android, iOS, and Windows platforms, as orientation changes could not be performed on macOS.
Output Video
Beforefix.mov
Afterfix.mov