Skip to content

[iOS] SwipeView Closes when Content Changes - right and bottom - fix #30182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfversluis merged 1 commit into from
Nov 30, 2025
Merged

[iOS] SwipeView Closes when Content Changes - right and bottom - fix #30182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed ...ols/tests/TestCases.Android.Tests/snapshots/android/SwipeViewShouldNotClose.png
View file
Open in desktop
Binary file not shown.
27 changes: 25 additions & 2 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue29086.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<SwipeItemView>
<Button
Text="+"
AutomationId="AddButton"
AutomationId="{Binding Value, StringFormat='AddButton{0}'}"
WidthRequest="40"
BackgroundColor="LightGreen"
Command="{Binding Source={x:Reference Self}, Path=IncrementCommand}"
Expand All @@ -32,9 +32,32 @@
</SwipeItemView>
</SwipeItems>
</SwipeView.LeftItems>
<SwipeView.RightItems>
<SwipeItems
Mode="Reveal"
SwipeBehaviorOnInvoked="RemainOpen">
<SwipeItemView>
<Button
Text="+"
AutomationId="{Binding Value, StringFormat='AddButtonRight{0}'}"
WidthRequest="40"
BackgroundColor="LightGreen"
Command="{Binding Source={x:Reference Self}, Path=IncrementCommand}"
CommandParameter="{Binding .}"/>
</SwipeItemView>
<SwipeItemView>
<Button
Text="-"
WidthRequest="40"
BackgroundColor="LightCoral"
Command="{Binding Source={x:Reference Self}, Path=DecrementCommand}"
CommandParameter="{Binding .}"/>
</SwipeItemView>
</SwipeItems>
</SwipeView.RightItems>

<Grid Padding="10"
AutomationId="SwipeItem"
AutomationId="{Binding Value, StringFormat='SwipeItem{0}'}"
BackgroundColor="LightBlue">
<Label Text="{Binding Value}"
FontSize="18"
Expand Down
1 change: 1 addition & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue29086.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ public Issue29086()
Numbers = new ObservableCollection<NumberItem>
{
new NumberItem { Value = 1 },
new NumberItem { Value = 2 },
};

IncrementCommand = new Command<NumberItem>((item) => item.Value++);
Expand Down
Binary file removed src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/SwipeViewShouldNotClose.png
View file
Open in desktop
Binary file not shown.
16 changes: 9 additions & 7 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29086.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,15 @@ public Issue29086(TestDevice testDevice) : base(testDevice)
[Category(UITestCategories.SwipeView)]
public void SwipeViewShouldNotClose()
{
App.WaitForElement("SwipeItem");
App.SwipeLeftToRight("SwipeItem");
App.WaitForElement("AddButton");
App.Click("AddButton");
App.WaitForElement("AddButton");
App.Click("AddButton");
VerifyScreenshot();
App.WaitForElement("SwipeItem1");
App.SwipeLeftToRight("SwipeItem1");
App.SwipeRightToLeft("SwipeItem2");
App.WaitForElement("AddButton1");
App.WaitForElement("AddButtonRight2");
App.Click("AddButton1");
App.Click("AddButtonRight2");
App.WaitForNoElement("AddButton1");
App.WaitForNoElement("AddButtonRight2");
}
}
#endif
11 changes: 6 additions & 5 deletions src/Core/src/Platform/iOS/MauiSwipeView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,20 +801,21 @@ void SwipeToThreshold(bool animated = true)
Animate(completeAnimationDuration, 0.0, UIViewAnimationOptions.CurveEaseIn,
() =>
{
_swipeOffset = GetSwipeThreshold();
_swipeOffset = Math.Abs(GetSwipeThreshold());

// If the user swiped left or up, we need a negative offset to move content in the correct direction on the screen.
if (_swipeDirection == SwipeDirection.Left || _swipeDirection == SwipeDirection.Up)
_swipeOffset = -_swipeOffset;

double swipeThreshold = _swipeOffset;

switch (_swipeDirection)
{
case SwipeDirection.Left:
_contentView.Frame = new CGRect(_originalBounds.X - swipeThreshold, _originalBounds.Y, _originalBounds.Width, _originalBounds.Height);
break;
case SwipeDirection.Right:
_contentView.Frame = new CGRect(_originalBounds.X + swipeThreshold, _originalBounds.Y, _originalBounds.Width, _originalBounds.Height);
break;
case SwipeDirection.Up:
_contentView.Frame = new CGRect(_originalBounds.X, _originalBounds.Y - swipeThreshold, _originalBounds.Width, _originalBounds.Height);
break;
case SwipeDirection.Down:
_contentView.Frame = new CGRect(_originalBounds.X, _originalBounds.Y + swipeThreshold, _originalBounds.Width, _originalBounds.Height);
break;
Expand Down