-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] SwipeView Closes when Content Changes - right and bottom - fix #30182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a large number of new and updated test cases spanning multiple issues to help ensure correct behavior across platforms. Key changes include new UI tests for issues such as SwipeView behavior (Issue29086), CollectionView layout (Issue29634, Issue29542), various Image and Button feature tests, and consistent namespace updates across test projects.
Reviewed Changes
Copilot reviewed 117 out of 460 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Tests/Issues/Issue29233.cs | Removed an extra "Tests" segment from the namespace. |
| HostApp/Issues/Issue7144.cs | Updated the namespace to align with new naming conventions. |
| HostApp/Issues/Issue6387.cs | Updated the namespace for consistency with current conventions. |
| HostApp/Issues/Issue15649.xaml.cs | Adjusted the namespace to follow the new standard for host app issues. |
Comments suppressed due to low confidence (4)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29233.cs:6
- The redundant 'Tests' segment in the original namespace has been removed, which improves clarity. Please confirm that all references to this namespace are updated accordingly.
namespace Microsoft.Maui.TestCases.Tests.Issues;
src/Controls/tests/TestCases.HostApp/Issues/Issue7144.cs:3
- The namespace has been updated from 'Controls.TestCases.HostApp.Issues' to 'Maui.Controls.Sample.Issues' to align with current conventions. Ensure consistency across all host app issue files.
namespace Maui.Controls.Sample.Issues;
src/Controls/tests/TestCases.HostApp/Issues/Issue6387.cs:1
- Namespace change to 'Maui.Controls.Sample.Issues' aligns with project standards; verify that dependent references are updated accordingly.
namespace Maui.Controls.Sample.Issues;
src/Controls/tests/TestCases.HostApp/Issues/Issue15649.xaml.cs:1
- Updating the namespace in this file to 'Maui.Controls.Sample.Issues' promotes consistency with other host app files. Please ensure any related XAML references are also updated.
namespace Maui.Controls.Sample.Issues;
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could include a test?
3310b65 to
f8f04ff
Compare
eb2da45 to
4a216e8
Compare
4684ea4 to
2938eb4
Compare
|
@kubaflo, I think a rebase might have gone wrong here, mind taking a quick look? |
205d3a4 to
ad707c9
Compare
249a31d to
e31b7b0
Compare
52d4bb0 to
2cc73ea
Compare
2cc73ea to
e6513f5
Compare
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi, @darrabam I see your problem :/ This PR hasn't been merged yet. That's why this fix is not in the public MAUI release yet |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@jfversluis Could you please merge this PR? I've tested 10.0.0-ci.net10.25524.17 and confirm that it fixes the issue. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Enhanced the Issue29086 test case to support multiple NumberItems and unique AutomationIds for SwipeView elements and buttons. Updated the UI and test logic to handle left and right swipe actions, and removed outdated snapshot images for Android, iOS, and Mac.
aa42dbe to
8c81ff3
Compare
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
A correction to this pr #29088 that fixes this comment #29088 (comment)
Issues Fixed
Fixes #29088 (comment)
Fixes #32033
Screen.Recording.2025-06-25.at.02.27.34.mov
Screen.Recording.2025-06-25.at.02.26.43.mov