Skip to content

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jun 25, 2025

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

A correction to this pr #29088 that fixes this comment #29088 (comment)

Issues Fixed

Fixes #29088 (comment)
Fixes #32033

Before After
Screen.Recording.2025-06-25.at.02.27.34.mov
Screen.Recording.2025-06-25.at.02.26.43.mov

Copilot AI review requested due to automatic review settings June 25, 2025 00:24
@kubaflo kubaflo requested a review from a team as a code owner June 25, 2025 00:24
@kubaflo kubaflo requested review from jfversluis and rmarinho June 25, 2025 00:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a large number of new and updated test cases spanning multiple issues to help ensure correct behavior across platforms. Key changes include new UI tests for issues such as SwipeView behavior (Issue29086), CollectionView layout (Issue29634, Issue29542), various Image and Button feature tests, and consistent namespace updates across test projects.

Reviewed Changes

Copilot reviewed 117 out of 460 changed files in this pull request and generated no comments.

File Description
Tests/Issues/Issue29233.cs Removed an extra "Tests" segment from the namespace.
HostApp/Issues/Issue7144.cs Updated the namespace to align with new naming conventions.
HostApp/Issues/Issue6387.cs Updated the namespace for consistency with current conventions.
HostApp/Issues/Issue15649.xaml.cs Adjusted the namespace to follow the new standard for host app issues.
Comments suppressed due to low confidence (4)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29233.cs:6

  • The redundant 'Tests' segment in the original namespace has been removed, which improves clarity. Please confirm that all references to this namespace are updated accordingly.
namespace Microsoft.Maui.TestCases.Tests.Issues;

src/Controls/tests/TestCases.HostApp/Issues/Issue7144.cs:3

  • The namespace has been updated from 'Controls.TestCases.HostApp.Issues' to 'Maui.Controls.Sample.Issues' to align with current conventions. Ensure consistency across all host app issue files.
namespace Maui.Controls.Sample.Issues;

src/Controls/tests/TestCases.HostApp/Issues/Issue6387.cs:1

  • Namespace change to 'Maui.Controls.Sample.Issues' aligns with project standards; verify that dependent references are updated accordingly.
namespace Maui.Controls.Sample.Issues;

src/Controls/tests/TestCases.HostApp/Issues/Issue15649.xaml.cs:1

  • Updating the namespace in this file to 'Maui.Controls.Sample.Issues' promotes consistency with other host app files. Please ensure any related XAML references are also updated.
namespace Maui.Controls.Sample.Issues;

@kubaflo kubaflo changed the base branch from main to inflight/current June 25, 2025 00:25
@kubaflo kubaflo changed the title Fix 29086 2 [iOS] SwipeView Closes when Content Changes - right and bottom - fix Jun 25, 2025
@kubaflo kubaflo self-assigned this Jun 25, 2025
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jun 25, 2025
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could include a test?

@kubaflo kubaflo force-pushed the fix-29086-2 branch 2 times, most recently from eb2da45 to 4a216e8 Compare June 25, 2025 22:42
@jsuarezruiz
Copy link
Contributor

@kubaflo, I think a rebase might have gone wrong here, mind taking a quick look?

@PureWeen PureWeen force-pushed the inflight/current branch 2 times, most recently from 205d3a4 to ad707c9 Compare June 28, 2025 02:00
@github-actions github-actions bot force-pushed the inflight/current branch 4 times, most recently from 249a31d to e31b7b0 Compare July 2, 2025 19:32
@github-actions github-actions bot force-pushed the inflight/current branch 2 times, most recently from 52d4bb0 to 2cc73ea Compare July 9, 2025 15:54
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen modified the milestones: .NET 9 SR10, .NET 9 SR12 Aug 4, 2025
@PureWeen PureWeen modified the milestones: .NET 9 SR12, .NET 10 SR1 Sep 10, 2025
@darrabam
Copy link

@kubaflo @PureWeen Somehow this fix hasn't move to 9.0.100 or 9.0.110. Would you please fix this issue in the latest release?

I hate to release my app using 9.0.100-ci.main.25403.2 😕

@kubaflo
Copy link
Contributor Author

kubaflo commented Sep 13, 2025

Hi, @darrabam I see your problem :/ This PR hasn't been merged yet. That's why this fix is not in the public MAUI release yet

@jfversluis
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen modified the milestones: .NET 10 SR1, .NET 10.0 SR2 Nov 4, 2025
@darrabam
Copy link

@jfversluis Could you please merge this PR? I've tested 10.0.0-ci.net10.25524.17 and confirm that it fixes the issue.

@kubaflo kubaflo changed the base branch from net10.0 to main November 28, 2025 12:47
@jfversluis
Copy link
Member

jfversluis commented Nov 28, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis changed the base branch from main to inflight/current November 30, 2025 07:03
Enhanced the Issue29086 test case to support multiple NumberItems and unique AutomationIds for SwipeView elements and buttons. Updated the UI and test logic to handle left and right swipe actions, and removed outdated snapshot images for Android, iOS, and Mac.
@github-project-automation github-project-automation bot moved this from Todo to Approved in MAUI SDK Ongoing Nov 30, 2025
@jfversluis jfversluis merged commit ecd4513 into dotnet:inflight/current Nov 30, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Nov 30, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

SwipeView Closes when Content Changes even with SwipeBehaviorOnInvoked="RemainOpen" (iOS only)

5 participants