[Windows] Fix for CarouselView IsSwipeEnabled=False Prevents Visual Navigation#29286
Merged
PureWeen merged 2 commits intodotnet:inflight/currentfrom May 5, 2025
Merged
Conversation
Contributor
|
Hey there @@SubhikshaSf4851! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
community ✨
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where setting IsSwipeEnabled to false disables the visual scrollbar, preventing programmatic navigation in CarouselView. Key changes include updating scrollbar visibility to "Hidden" on Windows and adding corresponding tests to ensure the fix works across platforms.
- Updated CarouselViewHandler.Windows.cs to use WScrollBarVisibility.Hidden instead of Disabled when IsSwipeEnabled is false.
- Added a test for the issue in TestCases.Shared.Tests.
- Updated TestCases.HostApp to host the revised CarouselView behavior.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29216.cs | Added test case to verify CarouselView scrolling behavior. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue29216.cs | Integrated test UI for CarouselView navigation. |
| src/Controls/src/Core/Handlers/Items/CarouselViewHandler.Windows.cs | Modified scrollbar visibility handling to resolve the scrolling bug. |
jsuarezruiz
added
platform/windows
area-controls-collectionview
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
previously approved these changes
May 5, 2025
PureWeen
approved these changes
May 5, 2025
PureWeen
pushed a commit
that referenced
this pull request
May 5, 2025
…avigation (#29286) * [Windows] Fix for Carousel View doesn't scroll programmatically * Test case sample
PureWeen
added a commit
that referenced
this pull request
May 8, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process ## .NET MAUI Release Notes - inflight/candidate This document contains release notes for changes from main branch to inflight/candidate branch. ### MAUI Product Fixes * [iOS] Fix: FlyoutPage memory leak by @bhavanesh001 in #28769 * [Windows] Fix for CarouselView IsSwipeEnabled=False Prevents Visual Navigation by @SubhikshaSF4852 in #29286 * [Windows] Fix for Argument Exception raised when the GetStringSize method of ICanvas called with default font by @SyedAbdulAzeemSF4852 in #29048 * Removed frame styles by @Vignesh-SF3580 in #29222 * [Android] Fixed the CollectionView Header and Footer Do Not Align with Horizontal ItemsLayout When EmptyView is Displayed by @Ahamed-Ali in #28779 * Add global xmlns in template by @StephaneDelcroix in #29203 * Fixed - On iOS GestureRecognizers don't work on Span in a Label, which doesn't get IsVisible (=true) update from its parent by @KarthikRajaKalaimani in #29024 * Fixed Footer not displayed at the Bottom When EmptyView in CV2 by @Dhivya-SF4094 in #28681 * Fixed typo in Connectivity.shared.cs by @corvinsz in #29213 ### Testing * Re-enabled flaky UI test TextInEditorShouldScroll by @NirmalKumarYuvaraj in #29167 * [Testing] Re-Enabled UI Test - Issue10222Test by @TamilarasanSF4853 in #29226 * [Testing] Feature Matrix UITest Cases for CollectionView Selection Feature by @LogishaSelvarajSF4525 in #29165 ### Dependency Updates *No dependency updates in this release* ### Docs *No documentation changes in this release* ### Housekeeping *No housekeeping changes in this release* ## New Contributors * @corvinsz made their first contribution in #29213 **Full Changelog**: main...inflight/candidate
SuthiYuvaraj
pushed a commit
to SuthiYuvaraj/maui
that referenced
this pull request
May 9, 2025
…avigation (dotnet#29286) * [Windows] Fix for Carousel View doesn't scroll programmatically * Test case sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
RootCause:
Setting IsSwipeEnabled = false disables scrollbar visibility, which prevents the CarouselView from scrolling when position changed programmatically.
Description of Change:
Using hidden for the scrollbar visibility instead of disabled resolves the issue and enables programmatic scrolling to function correctly.
Issues Fixed
Fixes #29216
Tested the behavior in the following platforms
Screenshot
Issue29216BeforeFix.mp4
Issue29216AfterFix.mp4