[Testing] Feature Matrix UITest Cases for CollectionView Selection Feature #29165
Merged
PureWeen merged 2 commits intoinflight/currentfrom Apr 28, 2025
unknown repository
Merged
[Testing] Feature Matrix UITest Cases for CollectionView Selection Feature #29165PureWeen merged 2 commits intoinflight/currentfrom unknown repository
PureWeen merged 2 commits intoinflight/currentfrom
unknown repository
Conversation
Contributor
|
Hey there @@LogishaSelvarajSF4525! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive UI test cases to validate the CollectionView selection features, including different selection modes and corresponding view model updates.
- Added a new SelectionOptionsPage with controls for simulating selection mode changes.
- Introduced a CollectionViewSelectionPage that enables navigation from the main feature page to the selection tests.
- Extended CollectionViewViewModel with properties and event handling for single and multiple selection scenarios, and updated CollectionViewFeaturePage to include navigation to the new test pages.
Reviewed Changes
Copilot reviewed 13 out of 16 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SelectionOptionsPage.xaml.cs | Added a page with buttons to change selection options and update the view model accordingly. |
| CollectionViewSelectionPage.xaml.cs | Created a new page to test selection functionality and navigate to the options page. |
| CollectionViewViewModel.cs | Extended the view model with new properties (SelectionMode, SelectedItem, SelectedItems, etc.) and event handlers for selection changes. |
| CollectionViewFeaturePage.xaml.cs | Added a navigation button to access the new selection test pages. |
Files not reviewed (3)
- src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewFeaturePage.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/Selection/CollectionViewSelectionPage.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/Selection/SelectionOptionsPage.xaml: Language not supported
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
previously approved these changes
Apr 25, 2025
PureWeen
approved these changes
Apr 28, 2025
PureWeen
pushed a commit
that referenced
this pull request
May 5, 2025
…ature (#29165) * added the selection feature tests * added snapshots
PureWeen
pushed a commit
that referenced
this pull request
May 5, 2025
…ature (#29165) * added the selection feature tests * added snapshots
PureWeen
added a commit
that referenced
this pull request
May 8, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process ## .NET MAUI Release Notes - inflight/candidate This document contains release notes for changes from main branch to inflight/candidate branch. ### MAUI Product Fixes * [iOS] Fix: FlyoutPage memory leak by @bhavanesh001 in #28769 * [Windows] Fix for CarouselView IsSwipeEnabled=False Prevents Visual Navigation by @SubhikshaSF4852 in #29286 * [Windows] Fix for Argument Exception raised when the GetStringSize method of ICanvas called with default font by @SyedAbdulAzeemSF4852 in #29048 * Removed frame styles by @Vignesh-SF3580 in #29222 * [Android] Fixed the CollectionView Header and Footer Do Not Align with Horizontal ItemsLayout When EmptyView is Displayed by @Ahamed-Ali in #28779 * Add global xmlns in template by @StephaneDelcroix in #29203 * Fixed - On iOS GestureRecognizers don't work on Span in a Label, which doesn't get IsVisible (=true) update from its parent by @KarthikRajaKalaimani in #29024 * Fixed Footer not displayed at the Bottom When EmptyView in CV2 by @Dhivya-SF4094 in #28681 * Fixed typo in Connectivity.shared.cs by @corvinsz in #29213 ### Testing * Re-enabled flaky UI test TextInEditorShouldScroll by @NirmalKumarYuvaraj in #29167 * [Testing] Re-Enabled UI Test - Issue10222Test by @TamilarasanSF4853 in #29226 * [Testing] Feature Matrix UITest Cases for CollectionView Selection Feature by @LogishaSelvarajSF4525 in #29165 ### Dependency Updates *No dependency updates in this release* ### Docs *No documentation changes in this release* ### Housekeeping *No housekeeping changes in this release* ## New Contributors * @corvinsz made their first contribution in #29213 **Full Changelog**: main...inflight/candidate
SuthiYuvaraj
pushed a commit
to SuthiYuvaraj/maui
that referenced
this pull request
May 9, 2025
…ature (dotnet#29165) * added the selection feature tests * added snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a comprehensive set of UI test cases for the CollectionView control. The tests validate the Selection feature functionality in CollectionView, including properties such as:SelectionMode, SelectedItem, SelectedItems, PreSelection, CurrentSelection, ItemsLayout, ItemsSource.
Related Issues in Selection Feature