[iOS] Back-navigation with swipe-back navigates back twice - fix#28485
Conversation
kubaflo
added
platform/ios
area-controls-shell
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
jfversluis
added
the
p/0
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
left a comment
mattleibow
left a comment
There was a problem hiding this comment.
Is it possible to write a UI test for this? I think that the swipe gestures should work?
github-project-automation
bot
moved this from Ready To Review
to Changes Requested
in MAUI SDK Ongoing
|
|
||
| public override UIViewController PopViewController(bool animated) | ||
| { | ||
| _popRequested = true; |
There was a problem hiding this comment.
Could you include an UITest based on https://github.com/Vetle444/MauiTestApp/tree/swipeBackBug?
Can use App.SwipeLeftToRight(); in the test.
There was a problem hiding this comment.
Unfortunately, it doesn't work for this iOS-specific-swipe-back gesture
There was a problem hiding this comment.
Doesn't it do anything? I can take a look and add it.
There was a problem hiding this comment.
That would be cool if you could figure it out
|
|
Author of the issue confirms this seems to fix it: #28446 (comment) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-project-automation
bot
moved this from Ready To Review
to Done
in MAUI SDK Ongoing
|
/backport to release/9.0.1xx-sr5 |
|
Started backporting to release/9.0.1xx-sr5: https://github.com/dotnet/maui/actions/runs/14043250116 |
|
@sheiksyedm I believe this should help :) #28644 |
7 participants
Description
I've made changes to iOS special back navigation in this PR: #24003, but didn't account for the siwpe gesture that behaves differently that the callout-menu-click navigation
Issues Fixed
Fixes #28446
Fixes #28572
Screen.Recording.2025-03-18.at.20.01.48.mov
Screen.Recording.2025-03-18.at.20.00.04.mov