[iOS] Using long-press navigation on back button with shell pages - fix#24003
Merged
jfversluis merged 3 commits intodotnet:mainfrom Feb 14, 2025
Merged
[iOS] Using long-press navigation on back button with shell pages - fix#24003jfversluis merged 3 commits intodotnet:mainfrom
jfversluis merged 3 commits intodotnet:mainfrom
Conversation
kubaflo
added
platform/ios
area-controls-shell
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
force-pushed
the
fix-23892
branch
from
9a78edc to
8f1e0a0
Compare
Contributor
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
kubaflo
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
force-pushed
the
fix-23892
branch
from
3a3929f to
0d481e6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jfversluis
requested changes
Dec 17, 2024
Member
jfversluis
left a comment
jfversluis
left a comment
There was a problem hiding this comment.
OK after 5 retries I think something might actually be wrong here 😅
The error also seems somewhat relevant to what is changed here so I think we should look into it: "[FAIL] Back Button Behavior Text"
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
@PureWeen I've added a UITest |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Update ShellSectionRenderer.cs
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
approved these changes
Feb 14, 2025
albyrock87
added a commit
to nalu-development/maui-custom
that referenced
this pull request
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The
[Export("navigationBar:shouldPopItem:")]is not being triggered when navigating back with the iOS's callout menuFixes #23892
Screen.Recording.2024-08-04.at.17.30.36.mov
Screen.Recording.2024-08-04.at.17.42.42.mov