Check if RefreshControl is enabled on iOS #28360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
requested review from
jfversluis and
rmarinho
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where replacing the content of the RefreshView on iOS inadvertently re-enables the progress spinner by adding additional checks and test coverage.
- Added a new test page in TestCases.HostApp to simulate replacing the RefreshView content
- Introduced corresponding automated tests in TestCases.Shared.Tests
- Updated the iOS MauiRefreshView to conditionally insert the refresh control based on its Enabled state
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.HostApp/Issues/Issue28343.cs | Added a test page to simulate RefreshView content replacement |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28343.cs | Added automated tests to verify the refresh spinner state |
| src/Core/src/Platform/iOS/MauiRefreshView.cs | Updated TryInsertRefresh to check if the refresh control is enabled |
|
So what calls TryInsertRefresh later when IsEnabled ? |
MapIsEnabled triggers TryInsertRefresh
Which is also validated by the following test |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
rmarinho
approved these changes
Mar 12, 2025
albyrock87
approved these changes
Mar 12, 2025
|
/backport to main |
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/maui/actions/runs/13822921226 |
rmarinho
approved these changes
Mar 12, 2025
kubaflo
approved these changes
Mar 12, 2025
kubaflo
approved these changes
Mar 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#28077 changed the ordering of some property mappers which revealed some scenarios where the order was hiding other bugs. For example, in this scenario if the user were to replace the content of the RefreshView that would cause it to become re-enabled.
Issues Fixed
Fixes #28343