Fixed FontImageSource icon color does not change in the TabbedPage when dynamically updated. #27742
Merged
PureWeen merged 2 commits intodotnet:mainfrom Feb 28, 2025
Merged
Conversation
…e when dynamically updated.
Contributor
|
Hey there @NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
karthikraja-arumugam
added
the
partner/syncfusion
jsuarezruiz
reviewed
Feb 12, 2025
Contributor
Author
@jsuarezruiz , Yes, this is the test case I am referring to. Once this gets merged, I will update the button click logic to change the color instead of setting a new FontImageSource. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Feb 27, 2025
tj-devel709
pushed a commit
that referenced
this pull request
Mar 3, 2025
…en dynamically updated. (#27742) * Fixed The FontImageSource icon color does not change in the TabbedPage when dynamically updated. * Updated code changes
bhavanesh2001
pushed a commit
to bhavanesh2001/maui
that referenced
this pull request
Mar 7, 2025
…en dynamically updated. (dotnet#27742) * Fixed The FontImageSource icon color does not change in the TabbedPage when dynamically updated. * Updated code changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Details
The FontImageSource Icon color of the TabbedPage is not updated at run time.
Root Cause
The SourceChanged event is not implemented for the IconImageSource in the Page.
Description of Change
Implementing a source changed event listener for IconImageSource in the ImageSource call back. When the ImageSource changes are detected, manually triggering PropertyChanged for IconImageSource.This propagates the change through the UI update mechanism, ensuring the TabbedPage icon reflects the new state.
Validated the behaviour in the following platforms
Issues Fixed
Fixes #27549
NOTE : This PR is dependent on the following PR's .
Android and iOS PR - #26757
Windows PR - #26888
TestCase - I will modify the testcase once the above PR's are merged.
Output
Before.mov
After.mov