[Windows] Fix for FontImageSource color is not applied to the Tab Icon on the TabbedPage by Tamilarasan-Paranthaman · Pull Request #26888 · dotnet/maui

Tamilarasan-Paranthaman · 2024-12-31T14:02:14Z

Root Cause of the issue

The FontImageSource icon color is not considered when applying the Icon's Foreground

Description of Change

The issue was resolved by storing the FontImageSource icon color in the IconColor property of the ViewModel. If IconColor is not null, the Foreground property retrieves the icon color and applies it to the icon's foreground. If IconColor is null, the Foreground property uses the SelectedForeground and UnselectedForeground values based on the IsSelected property and applies them to the icon's foreground.
Additionally, I have handled the dynamic updates to the Icon and IconColor properties in the OnPagePropertyChanged method

Issues Fixed

Fixes #26752

Test Case

The test case has already been added in the following PR. We can reenable it for Windows once the PR has been merged.
[iOS] [Android] Fix for the FontImageSource color is not applied properly to the Tab Icon #26757

Tested the behaviour in the following platforms

Windows
Android
iOS
Mac

Screenshot

Before Issue Fix	After Issue Fix

dotnet-policy-service · 2024-12-31T14:02:32Z

Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jfversluis · 2025-01-09T10:53:11Z

/azp run

azure-pipelines · 2025-01-09T10:53:31Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-01-14T11:12:01Z

src/Controls/src/Core/TabbedPage/TabbedPage.Windows.cs

 					(vm, page) =>
 					{
 						vm.Icon = page.IconImageSource?.ToIconSource(handler.MauiContext!)?.CreateIconElement();
+						vm.IconColor = (page.IconImageSource as FontImageSource)?.Color?.AsPaint()?.ToPlatform();


Could include an UITest and validate the colors with the VerifyScreenshot method?

The test case has already been added to the following PR. We can re-enable it for Windows once the PR has been merged.

PR : #26757

Or Do I need to add the same test case in this PR as well?

Yes, in this PR, remove the #if TEST_FAILS_ON_WINDOWS compilation directive from the FontImageSourceColorShouldApplyOnTabIcon test and commit the snapshot to validate the test.

src/Controls/src/Core/TabbedPage/TabbedPage.Windows.cs

jsuarezruiz · 2025-02-24T15:04:34Z

/rebase

jsuarezruiz · 2025-02-24T15:11:37Z

/azp run

azure-pipelines · 2025-02-24T15:12:25Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen

Can you grab the test that's on
#26757

And just include it here for now? That way we can test and validate this PR against that scenario?

We'll just resolve the conflicts once either of these merge

jsuarezruiz · 2025-03-05T10:37:08Z

#26757

Agree, will like to have the test from #26757 here to validate the changes directly without wait to merge. We can fix conflicts later if necessary.

jsuarezruiz

The fix looks good, but, could you include the test Issue26662 from https://github.com/dotnet/maui/pull/26757/files here?

Ahamed-Ali · 2025-03-06T09:47:45Z

The fix looks good, but, could you include the test Issue26662 from https://github.com/dotnet/maui/pull/26757/files here?

The test sample and the test case have been included. Could you please check? @jfversluis / @PureWeen

jsuarezruiz · 2025-03-26T07:57:15Z

/azp run

azure-pipelines · 2025-03-26T07:57:37Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-06-09T06:54:52Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-06-09T06:55:03Z

Azure Pipelines successfully started running 1 pipeline(s).

jfversluis · 2025-08-27T13:47:18Z

/rebase

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

azure-pipelines · 2025-08-27T13:53:57Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-policy-service bot added the community ✨ Community Contribution label Dec 31, 2024

Tamilarasan-Paranthaman added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 31, 2024

Tamilarasan-Paranthaman marked this pull request as ready for review January 3, 2025 14:24

Tamilarasan-Paranthaman requested a review from a team as a code owner January 3, 2025 14:24

Tamilarasan-Paranthaman requested review from StephaneDelcroix and mattleibow January 3, 2025 14:24

jfversluis added the area-controls-tabbedpage TabbedPage label Jan 9, 2025

jsuarezruiz reviewed Jan 14, 2025

View reviewed changes

jsuarezruiz self-assigned this Jan 14, 2025

Ahamed-Ali mentioned this pull request Feb 4, 2025

The FontImageSource icon color does not change in the TabbedPage when dynamically updated. #27549

Closed

NirmalKumarYuvaraj mentioned this pull request Feb 12, 2025

Fixed FontImageSource icon color does not change in the TabbedPage when dynamically updated. #27742

Merged

4 tasks

StephaneDelcroix previously approved these changes Feb 13, 2025

View reviewed changes

PureWeen requested changes Feb 13, 2025

View reviewed changes

src/Controls/src/Core/TabbedPage/TabbedPage.Windows.cs Show resolved Hide resolved

PureWeen added this to the .NET 9 SR5 milestone Feb 13, 2025

github-actions bot force-pushed the fix-26752 branch from 3e27b5e to e8c9d75 Compare February 24, 2025 15:06

jfversluis previously approved these changes Feb 25, 2025

View reviewed changes

jfversluis requested a review from PureWeen February 28, 2025 14:21

PureWeen requested changes Mar 3, 2025

View reviewed changes

github-project-automation bot moved this from Approved to Changes Requested in MAUI SDK Ongoing Mar 3, 2025

jsuarezruiz suggested changes Mar 5, 2025

View reviewed changes

Ahamed-Ali dismissed stale reviews from jfversluis and StephaneDelcroix via 8fa0858 March 5, 2025 15:52

PureWeen modified the milestones: .NET 9 SR6, .NET 9 SR7 Mar 24, 2025

Ahamed-Ali force-pushed the fix-26752 branch from 94eb152 to 278f923 Compare April 2, 2025 06:16

PureWeen modified the milestones: .NET 9 SR7, .NET 9 SR8 May 8, 2025

PureWeen removed this from MAUI SDK Ongoing May 8, 2025

PureWeen modified the milestones: .NET 9 SR8, .NET 9 Servicing May 8, 2025

github-actions bot force-pushed the fix-26752 branch from 048d2b2 to 03822a0 Compare August 27, 2025 13:48

Copilot AI review requested due to automatic review settings August 27, 2025 13:48

Copilot AI reviewed Aug 27, 2025

View reviewed changes

jfversluis approved these changes Aug 27, 2025

View reviewed changes

jfversluis changed the base branch from main to inflight/current August 29, 2025 12:08

Tamilarasan-Paranthaman and others added 6 commits August 29, 2025 14:09

MenuFlyoutSubItems fix

6f91c56

TabbedPage changes

7a4088d

Removed test sample

b7d8798

The test sample and case have been included.

28c61fc

Committed the windows snapshots

2b2be51

Committed the iOS and Android image

6f13ec1

jfversluis force-pushed the fix-26752 branch from 03822a0 to 6f13ec1 Compare August 29, 2025 12:09

jfversluis merged commit 4bf6a5d into dotnet:inflight/current Aug 29, 2025
1 check passed

jfversluis modified the milestones: .NET 9 Servicing, .NET 9 SR11 Aug 29, 2025

github-actions bot locked and limited conversation to collaborators Sep 29, 2025

Conversation

Tamilarasan-Paranthaman commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root Cause of the issue

Description of Change

Issues Fixed

Test Case

Tested the behaviour in the following platforms

Screenshot

Uh oh!

dotnet-policy-service bot commented Dec 31, 2024

Uh oh!

jfversluis commented Jan 9, 2025

Uh oh!

azure-pipelines bot commented Jan 9, 2025

Uh oh!

jsuarezruiz Jan 14, 2025

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jsuarezruiz commented Feb 24, 2025

Uh oh!

jsuarezruiz commented Feb 24, 2025

Uh oh!

azure-pipelines bot commented Feb 24, 2025

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Mar 5, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali commented Mar 6, 2025

Uh oh!

jsuarezruiz commented Mar 26, 2025

Uh oh!

azure-pipelines bot commented Mar 26, 2025

Uh oh!

jsuarezruiz commented Jun 9, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Jun 9, 2025

Uh oh!

jfversluis commented Aug 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Aug 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Tamilarasan-Paranthaman commented Dec 31, 2024 •

edited

Loading

jsuarezruiz commented Jun 9, 2025 •

edited by jfversluis

Loading