Skip to content

Conversation

@rolfbjarne
Copy link
Member

No description provided.

dalexsoto and others added 30 commits November 6, 2025 14:32
Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
This is file 27 of 47 files with nullability disabled in Foundation.

Changes made:
- Enabled nullable reference types
- Added comprehensive XML documentation for all public operators and methods
- Removed all 'To be added.' placeholders
- Added proper 'see cref' attributes throughout documentation
- Made explicit operator parameters nullable with ArgumentNullException.ThrowIfNull checks
- Fixed grammar and consistency in XML comments
- Added missing parameter documentation

Contributes towards #17285.

---------

Co-authored-by: GitHub Copilot <noreply@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This pull request updates the following dependencies

## From https://github.com/dotnet/dotnet

- **Subscription**: [7bea2f72-36de-4307-8c02-e200db7ccd92](https://maestro.dot.net/subscriptions?search=7bea2f72-36de-4307-8c02-e200db7ccd92)
- **Build**: [20251209.9](https://dev.azure.com/dnceng/internal/_build/results?buildId=2857769) ([294121](https://maestro.dot.net/channel/5173/github:dotnet:dotnet/build/294121))
- **Date Produced**: December 10, 2025 6:41:45 AM UTC
- **Commit**: [32aba8526ca0c037d185329fe779e8a288e986fc](dotnet/dotnet@32aba85)
- **Branch**: [release/10.0.1xx](https://github.com/dotnet/dotnet/tree/release/10.0.1xx)

- **Dependency Updates**:
  - From [10.0.2 to 10.0.2][1]
     - Microsoft.NET.Runtime.MonoTargets.Sdk
     - Microsoft.NET.ILLink.Tasks
     - Microsoft.NETCore.App.Ref
  - From [10.0.0-beta.25609.106 to 10.0.0-beta.25609.109][1]
     - Microsoft.DotNet.Arcade.Sdk
     - Microsoft.DotNet.Build.Tasks.Feed
     - Microsoft.DotNet.SharedFramework.Sdk
  - From [0.11.5-alpha.25609.106 to 0.11.5-alpha.25609.109][1]
     - Microsoft.DotNet.Cecil
  - From [10.0.2-servicing.25609.106 to 10.0.2-servicing.25609.109][1]
     - Microsoft.NET.ILLink
  - From [10.0.102-servicing.25609.106 to 10.0.102-servicing.25609.109][1]
     - Microsoft.NET.Sdk
  - From [10.0.102 to 10.0.102][1]
     - Microsoft.TemplateEngine.Authoring.Tasks

[1]: dotnet/dotnet@094213b...32aba85
This way we always check for available hard disk space (currently we don't
check for the API Diff pipeline).

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This pull request updates the following dependencies

## From https://github.com/dotnet/macios

- **Subscription**: [c0371266-dd6f-4959-822b-decc72d2d668](https://maestro.dot.net/subscriptions?search=c0371266-dd6f-4959-822b-decc72d2d668)
- **Build**: [20251210.2](https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=12929639) ([294145](https://maestro.dot.net/channel/3884/github:dotnet:macios/build/294145))
- **Date Produced**: December 10, 2025 11:30:43 AM UTC
- **Commit**: [69e5712](69e5712)
- **Branch**: [release/9.0.1xx](https://github.com/dotnet/macios/tree/release/9.0.1xx)

- **Dependency Updates**:
  - From [26.0.9782 to 26.0.9783][1]
     - Microsoft.iOS.Sdk.net9.0_26.0
     - Microsoft.MacCatalyst.Sdk.net9.0_26.0
     - Microsoft.macOS.Sdk.net9.0_26.0
     - Microsoft.tvOS.Sdk.net9.0_26.0

[1]: 5f56b8d...69e5712
This pull request updates the following dependencies

## From https://github.com/dotnet/dotnet

- **Subscription**: [7bea2f72-36de-4307-8c02-e200db7ccd92](https://maestro.dot.net/subscriptions?search=7bea2f72-36de-4307-8c02-e200db7ccd92)
- **Build**: [20251211.1](https://dev.azure.com/dnceng/internal/_build/results?buildId=2858858) ([294323](https://maestro.dot.net/channel/5173/github:dotnet:dotnet/build/294323))
- **Date Produced**: December 11, 2025 3:05:38 PM UTC
- **Commit**: [11af6ee5adad08cf5743e1578eea8c324d482f5e](dotnet/dotnet@11af6ee)
- **Branch**: [release/10.0.1xx](https://github.com/dotnet/dotnet/tree/release/10.0.1xx)

- **Dependency Updates**:
  - From [10.0.2 to 10.0.2][1]
     - Microsoft.NET.Runtime.MonoTargets.Sdk
     - Microsoft.NET.ILLink.Tasks
     - Microsoft.NETCore.App.Ref
  - From [10.0.0-beta.25609.109 to 10.0.0-beta.25611.101][1]
     - Microsoft.DotNet.Arcade.Sdk
     - Microsoft.DotNet.Build.Tasks.Feed
     - Microsoft.DotNet.SharedFramework.Sdk
  - From [0.11.5-alpha.25609.109 to 0.11.5-alpha.25611.101][1]
     - Microsoft.DotNet.Cecil
  - From [10.0.2-servicing.25609.109 to 10.0.2-servicing.25611.101][1]
     - Microsoft.NET.ILLink
  - From [10.0.102-servicing.25609.109 to 10.0.102-servicing.25611.101][1]
     - Microsoft.NET.Sdk
  - From [10.0.102 to 10.0.102][1]
     - Microsoft.TemplateEngine.Authoring.Tasks

[1]: dotnet/dotnet@32aba85...11af6ee
This is file 33 of 47 files with nullability disabled in Foundation.

Changes:
* Enabled nullability by replacing '#nullable disable' with '#nullable enable'
* Removed [SupportedOSPlatform] attributes without version numbers
* Replaced 'To be added' comments with proper XML documentation
* Added comprehensive XML comments for all public members
* Added 'see cref' attributes for type references
* Fixed whitespace in XML comments
* Updated exception handling to use ArgumentNullException.ThrowIfNull
* Added null-forgiving operators where necessary for Runtime.GetINativeObject calls
* Made operator overload parameters and return types nullable where appropriate
* Add more tests.

Contributes towards #17285.
This is file 29 of 47 files with nullability disabled in Foundation.

Changes made:
- Enabled nullable reference types
- Made internal field notificationCenter nullable (NSNotificationCenter?)
- Made ObservedData fields nullable to properly reflect optional values
- Made method parameters nullable where appropriate (fromObject, keys, aName, anObject)
- Replaced ArgumentNullException with ArgumentNullException.ThrowIfNull
- Removed 'To be added.' placeholder documentation
- Added comprehensive XML documentation for all public methods
- Added proper 'see cref' attributes throughout documentation
- Removed unnecessary whitespace in XML comments
- Improved documentation clarity and consistency
- Added missing exception documentation for ArgumentNullException

Contributes towards #17285.

---------

Co-authored-by: GitHub Copilot <noreply@github.com>
This is file 30 of 47 files with nullability disabled in Foundation.

Changes:
* Enabled nullable reference types
* Removed 'To be added' placeholder comments
* Added comprehensive XML documentation for TxtRecordData property
* Made TxtRecordData property nullable to match generated code

Contributes towards #17285.

---------

Co-authored-by: GitHub Copilot <copilot@github.com>
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne force-pushed the dev/rolf/bump-main-in-net11.0-2025-12-15 branch from 95ee6a4 to ad0eef7 Compare December 18, 2025 07:30
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #ad0eef7] Build passed (Build packages) ✅

Pipeline on Agent
Hash: ad0eef788eb9205971cf43f54f3288b2805ce6df [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #ad0eef7] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: ad0eef788eb9205971cf43f54f3288b2805ce6df [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ad0eef7] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: ad0eef788eb9205971cf43f54f3288b2805ce6df [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ad0eef7] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: ad0eef788eb9205971cf43f54f3288b2805ce6df [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ad0eef7] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: ad0eef788eb9205971cf43f54f3288b2805ce6df [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #ad0eef7] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: ad0eef788eb9205971cf43f54f3288b2805ce6df [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Failed to compare API and create generator diff 🔥

Error: 'make' failed for the hash b8f5f71.

Pipeline on Agent
Hash: ad0eef788eb9205971cf43f54f3288b2805ce6df [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #ad0eef7] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 121 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 13 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: ad0eef788eb9205971cf43f54f3288b2805ce6df [PR build]

@rolfbjarne rolfbjarne disabled auto-merge December 18, 2025 11:14
@rolfbjarne rolfbjarne merged commit d152d25 into net11.0 Dec 18, 2025
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants