[d17-2] [Foundation] Separate the cancellation tokens from the current inflight data. fixes #11799 #17183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vs-mobiletools-engineering-service2
requested review from
rolfbjarne and
mandel-macaque
as code owners
vs-mobiletools-engineering-service2
added
backported
bug
…net#16511) This introduces changes to ensure that the Github token is available at all provisionator invocations so that when we need to flip to using dl.internalx.com, there are no breakages.
…h the new storage. (dotnet#16594)
1 similar comment
1 similar comment
1 similar comment
1 similar comment
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
rolfbjarne
added
the
skip-api-comparison
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Closing this for now, we have packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This is only a PR to create packages on top of d17-2 with the fixes in #15678.
The following is a refactor of the way we do manage the cancelation of the rest of the inflight data, this new implementation tries to avoid the situation in which the runtime is not correctly giving us an inflight data wit a cancelation token.
This is an attempt to fix issue 11799 by ensuring that as long as we have a reference to the managed object we will have a reference to the cancelation token source. Since we never set it to null, there is no need to check.
For more info look at the conversation in #11799
Backport of #15678