[Foundation] Separate the cancellation tokens from the current inflight data. fixes #11799 #15678
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| inflight.ResponseSent = true; | ||
|
|
||
| // EVIL HACK: having TrySetResult inline was blocking the request from completing | ||
| Task.Run (() => inflight.CompletionSource.TrySetResult (httpResponse!)); |
There was a problem hiding this comment.
Glad we got rid of this additional thread.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
🔥 [PR Build] Build failed 🔥Build failed for the job 'Build packages' Pipeline on Agent |
|
🔥 Failed to compare API and create generator diff 🔥 Error: 'make' failed for the hash 66642b7. Pipeline on Agent |
|
For anyone watching this PR see the note here I made on needing validation and/or a sample project for this PR to move forward. |
|
/sudo backport xcode14.2 |
|
Backport Job to branch xcode14.2 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7121026 for more details. |
|
/sudo backport d17-2 |
|
Backport Job to branch d17-2 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7180507 for more details. |
|
/sudo backport xcode14.3 |
|
Backport Job to branch xcode14.3 Created! The magic is happening here |
|
Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7985050 for more details. |
The following is a refactor of the way we do manage the cancelation of the rest of the inflight data, this new implementation tries to avoid the situation in which the runtime is not correctly giving us an inflight data wit a cancelation token.
This is an attempt to fix issue 11799 by ensuring that as long as we have a reference to the managed object we will have a reference to the cancelation token source. Since we never set it to null, there is no need to check.
For more info look at the conversation in #11799