-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed X64Fact tests #5057
Fixed X64Fact tests #5057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 4 more X64Fact tests not fully enabled in TestPredictors.cs
with relation to Issue #1216
machinelearning/test/Microsoft.ML.Predictor.Tests/TestPredictors.cs
Lines 758 to 838 in adad3e4
[X64Fact("x86 fails. Associated GitHubIssue: https://github.com/dotnet/machinelearning/issues/1216")] | |
public void TestEnsembleCombiner() | |
{ | |
var dataPath = GetDataPath("breast-cancer.txt"); | |
var dataView = ML.Data.LoadFromTextFile(dataPath); | |
var predictors = new PredictorModel[] | |
{ | |
FastTree.TrainBinary(ML, new FastTreeBinaryTrainer.Options | |
{ | |
FeatureColumnName = "Features", | |
NumberOfTrees = 5, | |
NumberOfLeaves = 4, | |
LabelColumnName = DefaultColumnNames.Label, | |
TrainingData = dataView | |
}).PredictorModel, | |
AveragedPerceptronTrainer.TrainBinary(ML, new AveragedPerceptronTrainer.Options() | |
{ | |
FeatureColumnName = "Features", | |
LabelColumnName = DefaultColumnNames.Label, | |
NumberOfIterations = 2, | |
TrainingData = dataView, | |
NormalizeFeatures = NormalizeOption.No | |
}).PredictorModel, | |
LbfgsLogisticRegressionBinaryTrainer.TrainBinary(ML, new LbfgsLogisticRegressionBinaryTrainer.Options() | |
{ | |
FeatureColumnName = "Features", | |
LabelColumnName = DefaultColumnNames.Label, | |
OptimizationTolerance = 10e-4F, | |
TrainingData = dataView, | |
NormalizeFeatures = NormalizeOption.No | |
}).PredictorModel, | |
LbfgsLogisticRegressionBinaryTrainer.TrainBinary(ML, new LbfgsLogisticRegressionBinaryTrainer.Options() | |
{ | |
FeatureColumnName = "Features", | |
LabelColumnName = DefaultColumnNames.Label, | |
OptimizationTolerance = 10e-3F, | |
TrainingData = dataView, | |
NormalizeFeatures = NormalizeOption.No | |
}).PredictorModel | |
}; | |
CombineAndTestEnsembles(dataView, "pe", "oc=average", PredictionKind.BinaryClassification, predictors); | |
Done(); | |
} | |
[X64Fact("x86 fails. Associated GitHubIssue: https://github.com/dotnet/machinelearning/issues/1216")] | |
public void TestMulticlassEnsembleCombiner() | |
{ | |
var dataPath = GetDataPath("breast-cancer.txt"); | |
var dataView = ML.Data.LoadFromTextFile(dataPath); | |
var predictors = new PredictorModel[] | |
{ | |
LightGbm.TrainMulticlass(Env, new LightGbmMulticlassTrainer.Options | |
{ | |
FeatureColumnName = "Features", | |
NumberOfIterations = 5, | |
NumberOfLeaves = 4, | |
LabelColumnName = DefaultColumnNames.Label, | |
TrainingData = dataView | |
}).PredictorModel, | |
LbfgsMaximumEntropyMulticlassTrainer.TrainMulticlass(Env, new LbfgsMaximumEntropyMulticlassTrainer.Options() | |
{ | |
FeatureColumnName = "Features", | |
LabelColumnName = DefaultColumnNames.Label, | |
OptimizationTolerance = 10e-4F, | |
TrainingData = dataView, | |
NormalizeFeatures = NormalizeOption.No | |
}).PredictorModel, | |
LbfgsMaximumEntropyMulticlassTrainer.TrainMulticlass(Env, new LbfgsMaximumEntropyMulticlassTrainer.Options() | |
{ | |
FeatureColumnName = "Features", | |
LabelColumnName = DefaultColumnNames.Label, | |
OptimizationTolerance = 10e-3F, | |
TrainingData = dataView, | |
NormalizeFeatures = NormalizeOption.No | |
}).PredictorModel | |
}; | |
CombineAndTestEnsembles(dataView, "weightedensemblemulticlass", "oc=multiaverage", PredictionKind.MulticlassClassification, predictors); | |
} |
These tests cause crashes during runs, should be explored more in the near future, and re-enabled under a different PR.
Yes, I noticed that too when I was debugging earlier. Can you please do me a favor? Now that we have gone towards different baselines, I think it would be good to be able to easily track which tests are using configuration specific baselines. Can you please add some code in BaseTestBaseline.cs to log whenever we use a configuration specific baseline? I just realized that this is something we should do. In reply to: 399621483 [](ancestors = 399621483) |
You can do it as a separate PR if you wish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit 21ef056.
I will make a separate PR for logging when a configuration specific benchmark is utilized. |
Fixed X64Fact tests with x86 specific baselines added
Currently obtaining baselines from x86 builds from CI