Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and deal with the remaining x86 baseline differences #1215

Closed
tannergooding opened this issue Oct 10, 2018 · 2 comments
Closed
Labels
P2 Priority of the issue for triage purpose: Needs to be fixed at some point. test related to tests

Comments

@tannergooding
Copy link
Member

The x86 build of ML.NET has some remaining baseline differences that need investigation and fixing.

From initial investigation, the remaining differences have fewer than 4 matching significant digits and this may be caused by known bugs in the double parsing code (which have already been fixed or are actively being fixed in .NET Core). Other differences are due to the implementation (between x86 and x64) of some floating-point Math functions that the tests depend on.

@tannergooding
Copy link
Member Author

The tests disabled for x86 can be identified by: [ConditionalFact(typeof(Environment), nameof(Environment.Is64BitProcess))]. Many of them have an additional comment on the same line of // x86 output differs from Baseline

@harishsk harishsk added the P2 Priority of the issue for triage purpose: Needs to be fixed at some point. label Jan 10, 2020
@antoniovs1029 antoniovs1029 added the test related to tests label Apr 15, 2020
@frank-dong-ms-zz
Copy link
Contributor

Created separate baseline for x86 tests: #5057

Some of the difference from x64 and x86 is due to MKL is generating different results.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Priority of the issue for triage purpose: Needs to be fixed at some point. test related to tests
Projects
None yet
Development

No branches or pull requests

4 participants