Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated build docs for .NET Core 3.1 #4967

Merged
merged 3 commits into from
Mar 24, 2020
Merged

Updated build docs for .NET Core 3.1 #4967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c8cc05
Updated build docs for .NET Core 3.1
mstfbl Mar 24, 2020
cfd143a
Update netcoreapp3.1-instructions.md
mstfbl Mar 24, 2020
b4b26cc
Update netcoreapp3.1-instructions.md
mstfbl Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/building/netcoreapp3.0-instructions.md → docs/building/netcoreapp3.1-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ML.NET now builds for .NET Core 3.0 by default. However to run tests on .NET Core 3.0, you need to do a few manual steps.
ML.NET now builds for .NET Core 3.1 by default. However to run tests on .NET Core 3.1, you need to do a few manual steps.
Copy link
Contributor

@harishsk harishsk Mar 24, 2020 •
edited by mstfbl
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this accurate? I think we build for netcoreapp21 when you run build. #Resolved

Copy link
Contributor Author

@mstfbl mstfbl Mar 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The src files always build on both netstandard2.0 and netcoreapp3.1. Meanwhile the tests only build on one target framework at a time: netcoreapp2.1, net461 or netcoreapp3.1 (Thanks @eerhardt !) I updated this document to reflect this. #Resolved


1. Run `.\build.cmd -- /p:Configuration=Release-netcoreapp3_1` or `.\build.cmd -Release-netcoreapp3_1` from the root of the repo.
2. If you want to build the NuGet packages, `.\build.cmd -buildPackages` after step 1.
Expand Down
6 changes: 3 additions & 3 deletions docs/building/unix-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ The following components are needed:
* libunwind8
* libomp-dev
* curl
* All the requirements necessary to run .NET Core 3.0 applications: libssl1.0.0 (1.0.2 for Debian 9) and libicu5x (libicu52 for ubuntu 14.x, libicu55 for ubuntu 16.x, and libicu57 for ubuntu 17.x). For more information on prerequisites in different linux distributions click [here](https://docs.microsoft.com/en-us/dotnet/core/linux-prerequisites?tabs=netcore30).
* All the requirements necessary to run .NET Core 3.1 applications: libssl1.0.0 (1.0.2 for Debian 9) and libicu5x (libicu55 for ubuntu 16.x, and libicu57 for ubuntu 17.x). For more information on prerequisites in different linux distributions click [here](https://docs.microsoft.com/en-us/dotnet/core/linux-prerequisites?tabs=netcore30).

For example, for Ubuntu 16.x:

Expand All @@ -41,14 +41,14 @@ sudo apt-get install libomp-dev

### macOS

macOS 10.13 (High Sierra) or higher is needed to build dotnet/machinelearning. We are using a .NET Core 3.0 SDK to build, which supports 10.13 or higher.
macOS 10.13 (High Sierra) or higher is needed to build dotnet/machinelearning. We are using a .NET Core 3.1 SDK to build, which supports 10.13 or higher.

On macOS a few components are needed which are not provided by a default developer setup:
* cmake 3.10.3
* libomp 7
* libgdiplus
* gettext
* All the requirements necessary to run .NET Core 3.0 applications. To view macOS prerequisites click [here](https://docs.microsoft.com/en-us/dotnet/core/macos-prerequisites?tabs=netcore30).
* All the requirements necessary to run .NET Core 3.1 applications. To view macOS prerequisites click [here](https://docs.microsoft.com/en-us/dotnet/core/macos-prerequisites?tabs=netcore30).

One way of obtaining CMake and other required libraries is via [Homebrew](https://brew.sh):
```sh
Expand Down
6 changes: 3 additions & 3 deletions docs/building/windows-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ You can build ML.NET either via the command line or by using Visual Studio.

## Required Software

1. **[Visual Studio 2019 Version 16.3](https://www.visualstudio.com/downloads/) (Community, Professional, Enterprise)** The Community version is completely free. The below build instructions were verified for VS 16.3.
1. **[Visual Studio 2019 Version 16.4+](https://www.visualstudio.com/downloads/) (Community, Professional, Enterprise)** The Community version is completely free. The below build instructions were verified for VS 16.4.
2. **[CMake](https://cmake.org/)** must be installed from [the CMake download page](https://cmake.org/download/#latest) and added to your path.

### Visual Studio 2019 Installation
We have successfully verified the below build instructions for Visual Studio version 16.3 and higher.
We have successfully verified the below build instructions for Visual Studio version 16.4 and higher.

#### Visual Studio 2019 - 'Workloads' based install

Expand All @@ -28,7 +28,7 @@ The following are the minimum requirements:

The following are the minimum requirements:
* C# and Visual Basic Roslyn Compilers
* .NET Core 3.0 SDK
* .NET Core 3.1 SDK
* Static Analysis Tools
* .NET Portable Library Targeting Pack
* Visual Studio C++ Core Features
Expand Down