Updated build docs for .NET Core 3.1 #4967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishsk
reviewed
Mar 24, 2020
| @@ -1,4 +1,4 @@ | |||
| ML.NET now builds for .NET Core 3.0 by default. However to run tests on .NET Core 3.0, you need to do a few manual steps. | |||
| ML.NET now builds for .NET Core 3.1 by default. However to run tests on .NET Core 3.1, you need to do a few manual steps. | |||
There was a problem hiding this comment.
Is this accurate? I think we build for netcoreapp21 when you run build. #Resolved
There was a problem hiding this comment.
The src files always build on both netstandard2.0 and netcoreapp3.1. Meanwhile the tests only build on one target framework at a time: netcoreapp2.1, net461 or netcoreapp3.1 (Thanks @eerhardt !) I updated this document to reflect this. #Resolved
harishsk
approved these changes
Mar 24, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Windows and Unix build docs for .NET Core 3.1.
Some specific things to note:
netstandard2.0andnetcoreapp3.1, and /tests only build on one target framework at a time:netcoreapp2.1,net461ornetcoreapp3.1