Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onnx export support for CopyColumns #4486

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Added onnx export support for CopyColumns #4486

merged 1 commit into from
Nov 27, 2019

Conversation

harishsk
Copy link
Contributor

Fixes #4218

@harishsk harishsk requested a review from a team as a code owner November 18, 2019 23:11
@harishsk harishsk requested a review from ganik November 18, 2019 23:11
Copy link
Member

@ganik ganik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs closed this Nov 22, 2019
@codemzs codemzs reopened this Nov 22, 2019
@codemzs
Copy link
Member

codemzs commented Nov 22, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #4486 into master will increase coverage by 0.01%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##           master    #4486      +/-   ##
==========================================
+ Coverage    74.9%   74.92%   +0.01%     
==========================================
  Files         908      908              
  Lines      160072   160097      +25     
  Branches    17222    17226       +4     
==========================================
+ Hits       119903   119947      +44     
+ Misses      35359    35344      -15     
+ Partials     4810     4806       -4
Flag Coverage Δ
#Debug 74.92% <96.55%> (+0.01%) ⬆️
#production 70.26% <80%> (+0.01%) ⬆️
#test 90.28% <100%> (ø) ⬆️
Impacted Files Coverage Δ
test/Microsoft.ML.Tests/OnnxConversionTest.cs 95.04% <100%> (+0.12%) ⬆️
src/Microsoft.ML.Data/Transforms/ColumnCopying.cs 96.15% <80%> (+10.71%) ⬆️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.26% <0%> (+0.15%) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 85.31% <0%> (+0.2%) ⬆️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 83.05% <0%> (+0.84%) ⬆️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 83.19% <0%> (+3.36%) ⬆️

@harishsk
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@harishsk harishsk merged commit 549b389 into dotnet:master Nov 27, 2019
@harishsk harishsk deleted the copycols branch April 21, 2020 23:57
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CopyColumns does not support saving to Onnx
3 participants