Delete build files before packaging and increase build timeout #4377
Conversation
…)" This reverts commit c922529.
|
Do we know what the issue is here? |
Codecov Report
@@ Coverage Diff @@
## master #4377 +/- ##
==========================================
- Coverage 74.66% 74.65% -0.02%
==========================================
Files 883 883
Lines 155117 155117
Branches 16931 16931
==========================================
- Hits 115814 115795 -19
- Misses 34558 34572 +14
- Partials 4745 4750 +5
|
I just added a commit here d3742e4 to add a step to clean-up before building packages on Windows. Later we can add the step for Unix as the script would be different and didn't want to invest much time on it now. I did some local investigation. After building, downloading test data and running tests the repo size grows to 16GB, after the clean-up it goes down to 1.5GBs which I believe is enough to build packages without hitting the space issue. Also I did a test build and it didn't repro anymore, however there where 2 timeouts... I think bumping the timeout to 50mins shouldn't hurt. |
codemzs
changed the title
| @@ -10,7 +10,7 @@ parameters: | |||
| jobs: | |||
| - job: ${{ parameters.name }} | |||
| ${{ if eq(parameters.codeCoverage, 'false') }}: | |||
| timeoutInMinutes: 40 | |||
| timeoutInMinutes: 60 | |||
There was a problem hiding this comment.
We should really be careful about letting our builds take so long. This isn't a huge project, and having an hour CI time doesn't seem great. Maybe someone should investigate what is taking so long in our builds.
There was a problem hiding this comment.
Eric, I will revert this back after the release. We have a huge backlog of PRs that is threatening the release.
In reply to: 339138790 [](ancestors = 339138790)
There was a problem hiding this comment.
Agreed - we need to get unblocked in the short term. I meant to say that someone should investigate it after this gets us unblocked.
There was a problem hiding this comment.
I suspect the reason our build times went up is because of newly added TensorFlow tests that each take easily a minute to run. We can try to reduce the dataset size but obviously after this release.
…t#4377) * Revert "Move windows build machines to NetCorePublic-Pool. (dotnet#4375)" This reverts commit c922529. * Add step to cleanup test data before building packages to free up space * Increase build timeout.
ghost
locked as resolved and limited conversation to collaborators
This reverts commit c922529 and deletes build files before packaging to get rid of out of memory error. It also increases the build timeout to 60 minutes.