add projects capability in CodeGenerator #5002
Conversation
| <ProjectCapability Include="MLNETCLIGenerated" /> | ||
| <#}else{#> | ||
| <ProjectCapability Include="ModelBuilderGenerated" /> | ||
| <#}#> |
There was a problem hiding this comment.
What's diverging between CLI and MB that we need MLNETCLIGenerated vs ModelBuilderGenerated?
There was a problem hiding this comment.
It's from our PM, we want to differentiate ModelBuilder-Generated from MLNet CLI Generated in telemetry data
| this.Write(" <ProjectCapability Include=\"MLNETCLIGenerated\" />\r\n"); | ||
| }else{ | ||
| this.Write(" <ProjectCapability Include=\"ModelBuilderGenerated\" />\r\n"); | ||
| } |
There was a problem hiding this comment.
Should modify the upstream .tt so the .cs is formatted properly here.
There was a problem hiding this comment.
Same w/ ModelProject.tt
There was a problem hiding this comment.
What you mean
There was a problem hiding this comment.
@LittleLittleCloud aren't these files generated from TT files?
There was a problem hiding this comment.
In this PR it looks like the CS files were modified directly instead of changing the TT files.
There was a problem hiding this comment.
Nevermind I see them now :)
There was a problem hiding this comment.
The newly added code is currently being formatted as:
It should be:
this.Write(this.ToStringHelper.ToStringWithCulture(Namespace));
this.Write(".Model.csproj\" />\r\n </ItemGroup>\r\n\r\n <ItemGroup>\r\n");
if (Target==CSharp.GenerateTarget.Cli) {
this.Write(" <ProjectCapability Include=\"MLNETCLIGenerated\" />\r\n");
}
else {
this.Write(" <ProjectCapability Include=\"ModelBuilderGenerated\" />\r\n");
}
this.Write(" </ItemGroup>\r\n</Project>\r\n");
return this.GenerationEnvironment.ToString();
}The generated .cs files are created from their corresponding .tt T4 template files. The change would occur there. I left a comment on the .cs as it shows the output.
There was a problem hiding this comment.
@JakeRadMSFT it's auto-gen, I didn't modify those cs file a bit :)
| @@ -54,4 +62,5 @@ public bool IncludeResNet18Package {get; set;} | |||
| public bool IncludeRecommenderPackage {get;set;} | |||
| public string StablePackageVersion {get;set;} | |||
| public string UnstablePackageVersion {get;set;} | |||
| internal CSharp.GenerateTarget Target {get;set;} | |||
There was a problem hiding this comment.
NIT: I would think of CLI vs ModelBuilder as the Source instead of Target. It's the thing causing the projects to get generated.
There was a problem hiding this comment.
LGTM; I'd recommend improving the code formatting: #5002 (review)
|
Current CI error on one Centos and one Ubuntu run is: - ##[error]Unhandled exception. System.IO.IOException: No space left on device@harishsk: Thoughts on how to resolve? |
@frank-dong-ms I believe you are already looking at this, aren't you? |
JakeRadMSFT
changed the title
ghost
locked as resolved and limited conversation to collaborators
if generated by ModelBuilder, will add
<ProjectCapability Include="ModelBuilderGenerated" />else
<ProjectCapability Include="MLNETCLIGenerated" />to .Model and .Console project