[tests] add IgnoreInterpreter category for one test #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Oct 19, 2021
|
Testing this will be properly ignored here: dotnet/android#6363 |
Context: https://github.com/xamarin/xamarin-android/pull/6363
Context: https://github.com/xamarin/xamarin-android/pull/6363#issuecomment-937379007
Context: https://github.com/xamarin/java.interop/pull/893
Context: https://github.com/dotnet/runtime/issues/60638
Context: https://github.com/dotnet/runtime/compare/491ed9a112559872c31ae40da8f6d9977ba4ce3a...e013f14c5330375a18656dea8dca14e5602a3ae0
An "odd" problem arose in xamarin/xamarin-android#6363, which
attempted to bump to dotnet/runtime@e013f14c:
the [`JavaObjectTest.Dispose_Finalized()` test][0] started failing.
Doubly odd is that this test has been working fine for *years*, and
there are no "obviously relevant" changes in the dotnet/runtime diff.
There was a suggestion to use try using
[`FinalizeHelpers.PerformNoPinAction()`][1], but this didn't fix the
failing unit test.
In order to "unblock" the dotnet/runtime bump in
xamarin/xamarin-android, add a `[Category ("IgnoreInterpreter")]` to
the `Dispose_Finalized()` test, so that it can be ignored for now.
We have also filed dotnet/runtime#60638 to track a proper fix.
[0]: https://github.com/xamarin/java.interop/blob/4277ac96eb4f2dd191e86f7bc1b72f7bdd4fbb0c/tests/Java.Interop-Tests/Java.Interop/JavaObjectTest.cs#L112-L129
[1]: https://github.com/mono/mono/blob/8266c5604b8c03882f2b06af27fdea46b142d6b9/mono/mini/TestHelpers.cs#L12-L44 |
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Oct 20, 2021
This reverts commit b6d1a0a.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/runtime#60638