Skip to content

Commit d1d64c1

Browse files
[tests] add [Category("IgnoreInterpreter")] to Dispose_Finalized() (#895)
Context: dotnet/android#6363 Context: dotnet/android#6363 (comment) Context: #893 Context: dotnet/runtime#60638 Context: dotnet/runtime@491ed9a...e013f14 An "odd" problem arose in dotnet/android#6363, which attempted to bump to dotnet/runtime@e013f14c: the [`JavaObjectTest.Dispose_Finalized()` test][0] started failing. Doubly odd is that this test has been working fine for *years*, and there are no "obviously relevant" changes in the dotnet/runtime diff. There was a suggestion to use try using [`FinalizeHelpers.PerformNoPinAction()`][1], but this didn't fix the failing unit test. In order to "unblock" the dotnet/runtime bump in xamarin/xamarin-android, add a `[Category ("IgnoreInterpreter")]` to the `Dispose_Finalized()` test, so that it can be ignored for now. We have also filed dotnet/runtime#60638 to track a proper fix. [0]: https://github.com/xamarin/java.interop/blob/4277ac96eb4f2dd191e86f7bc1b72f7bdd4fbb0c/tests/Java.Interop-Tests/Java.Interop/JavaObjectTest.cs#L112-L129 [1]: https://github.com/mono/mono/blob/8266c5604b8c03882f2b06af27fdea46b142d6b9/mono/mini/TestHelpers.cs#L12-L44
1 parent 2d5431f commit d1d64c1

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

tests/Java.Interop-Tests/Java.Interop/JavaObjectTest.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,8 @@ public void Dispose ()
110110

111111
#if !NO_GC_BRIDGE_SUPPORT
112112
[Test]
113+
// See: https://github.com/dotnet/runtime/issues/60638
114+
[Category ("IgnoreInterpreter")]
113115
public void Dispose_Finalized ()
114116
{
115117
var d = false;

0 commit comments

Comments
 (0)