Regenerate device listing #1966
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| distance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,7 @@ | |
| "power", | ||
| "voc", | ||
| "thermocouple", | ||
| "weight", | ||
|
Member
There was a problem hiding this comment. while you are there, don't you want to make the little changes used here to move to a json file? :-) https://github.com/nanoframework/Samples/tree/main/device-listing If not, no worry, that can be done later.
Member
Author
There was a problem hiding this comment. I'd prefer to do that later, unfortunately don't have much time this week as I'm preparing for .NET Conf and I'd like the new devices to be available on device listing since they're used in the presentation :-) |
||
| }; | ||
|
|
||
| Dictionary<string, string?> categoriesDescriptions = new() | ||
|
|
@@ -103,6 +104,7 @@ | |
| { "multi", "Multi-device or robot kit" }, | ||
| { "lidar", "LIDAR Time of Flight devices" }, | ||
| { "thermocouple", "Thermocouple devices" }, | ||
| { "weight", "Weight sensors" }, | ||
| // Bucket for stuff we want mentioned but there is no clear category | ||
| // In other words: anything allowing a way to create PWM channel, SPI/I2C/... device | ||
| { "protocol", "Protocols providers/libraries" }, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while regenerating this file, what about going to the title of the README and adjusting them to add more about the device names? Like this one: https://github.com/dotnet/iot/blob/main/src/devices/Bmxx80/README.md
Would be great to list of the devices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created #1967 to track all comments you've put here but unfortunately I'd prefer this one was scoped to simple change. I was thinking about doing this before I opened PR but realized I'm a bit short on time so decided to just do simple change