Skip to content

Don't run binary tooling during license scan setup #19015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

ellahathaway
Copy link
Member

As part of #18726, binary tooling runs automatically as part of eng/prep-source-build.sh unless --no-binary-tooling is passed.

The license scan currently makes use of eng/prep-source-build.sh with binary tooling enabled, but it should not make use of the binary tooling. In fact, when it attempts to set up for the binary tooling, the following error is received due to the args currently passed to eng/prep-source-build.sh in the pipeline:

ERROR: A pre-existing package archive is needed if --with-packages is not provided. Please either supply a source-feed using --with-packages or execute ./eng/prep-source-build.sh with download artifacts enabled before proceeding. Exiting...

This can be fixed by passing --no-binary-tooling to eng/prep-souce-build.sh when license scanning.

Link to failing run (internal link)

Link to successful run (internal link)

@ellahathaway ellahathaway requested a review from mthalman March 12, 2024 21:07
@ellahathaway ellahathaway enabled auto-merge (squash) March 12, 2024 21:15
@ellahathaway ellahathaway merged commit aa15647 into dotnet:main Mar 12, 2024
@ellahathaway ellahathaway deleted the binaries-license-scan branch March 22, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants