Binary tooling #18726
Merged
Binary tooling #18726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichaelSimons @mthalman - This is still a work in progress, but I wanted to get your thoughts on the configuration of this tool. Ideally, the tool will work by running |
mthalman
reviewed
Feb 21, 2024
src/SourceBuild/content/eng/tools/BinaryDetection/BinaryDetection/BinaryDetection.csproj
Outdated
Show resolved
Hide resolved
mthalman
reviewed
Feb 26, 2024
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryToolCli/BinaryToolCli.csproj
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/BinaryTool.csproj
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryToolCli/nuget.config
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryToolTask/BinaryToolTask.csproj
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/CompareBinariesAgainstBaseline.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/Driver.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/Driver.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/Driver.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/ProcessManager.cs
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Feb 26, 2024
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/BinaryTool.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Feb 26, 2024
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryToolTask/BinaryToolTask.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Feb 26, 2024
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryToolTask/BinaryToolTask.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Feb 26, 2024
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryToolCli/BinaryToolCli.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Feb 26, 2024
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryToolCli/Program.cs
Outdated
Show resolved
Hide resolved
…fy functionality w RMEs
premun
reviewed
Feb 27, 2024
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/CompareBinariesAgainstBaselines.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/DetectBinaries.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/Driver.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/Driver.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/RemoveBinaries.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryToolCli/Program.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryToolCli/Program.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/Driver.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/DetectBinaries.cs
Outdated
Show resolved
Hide resolved
mthalman
reviewed
Feb 27, 2024
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/DetectBinaries.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/BinaryTool/CompareBinariesAgainstBaselines.cs
Outdated
Show resolved
Hide resolved
mthalman
reviewed
Mar 7, 2024
src/SourceBuild/content/eng/tools/BinaryToolKit/DetectBinaries.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/eng/tools/BinaryToolKit/DetectBinaries.cs
Outdated
Show resolved
Hide resolved
ellahathaway
force-pushed
the
binarytooling
branch
from
a62be65 to
2fe5175
Compare
mthalman
reviewed
Mar 8, 2024
ellahathaway
force-pushed
the
binarytooling
branch
from
8bee5d7 to
6616e41
Compare
mthalman
approved these changes
Mar 11, 2024
ellahathaway
force-pushed
the
binarytooling
branch
from
d4d6cae to
b63671b
Compare
MichaelSimons
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/source-build#4089 and dotnet/source-build#4108
This PR introduces tooling to detect, validate, and remove binaries. This tooling can be used on any given
TargetDirectory, and it is integrated intoprep-source-build.sh.This tool follows the file globbing parameters as specified in https://learn.microsoft.com/en-us/dotnet/api/microsoft.extensions.filesystemglobbing.matcher?view=dotnet-plat-ext-8.0#remarks. The
allowed-binaries.txtfile was modified in this PR to comply with those patterns.Sample run (updated 3/1/24): https://dev.azure.com/dnceng/internal/_build/results?buildId=2391859&view=results (internal link)