Propagate RID properties set in source-build to sdk repo #17197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmds
reviewed
Aug 16, 2023
| @@ -7,6 +7,10 @@ | |||
| <BuildCommandArgs>$(BuildCommandArgs) /p:PackageProjectUrl=https://github.com/dotnet/sdk</BuildCommandArgs> | |||
| <BuildCommandArgs>$(BuildCommandArgs) /p:PublishCompressedFilesPathPrefix=$(SourceBuiltToolsetDir)</BuildCommandArgs> | |||
|
|
|||
| <!-- Propagate RID set in source-build to sdk repo --> | |||
| <BuildCommandArgs>$(BuildCommandArgs) /p:PortableRid=$(PortableRid)</BuildCommandArgs> | |||
There was a problem hiding this comment.
PortableRid doesn't detect musl.
For updating the rid graph in the runtime repo, we've been using NETCoreSdkPortableRuntimeIdentifier:
installer/src/SourceBuild/content/repo-projects/runtime.proj
Lines 21 to 22 in 23922bc
mthalman
approved these changes
Aug 16, 2023
This was referenced Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sdk repo needs the RID from source-build so that it can update its trimmed down RID graph with the non-portable RID. This propagates the
TargetRidandPortableRidproperties to sdk during source builds.Contributes to dotnet/source-build#3584
cc @dsplaisted @tmds