Skip to content

Add AdditionalRuntimeIdentifier if building from source #34650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2023
Merged

Add AdditionalRuntimeIdentifier if building from source #34650

merged 2 commits into from
Aug 17, 2023

Conversation

elinor-fung
Copy link
Member

Specify RID to add to graph per mechanism in #34279

This needs dotnet/installer#17197 to actually work (TargetRid is currently not set).

Fixes dotnet/source-build#3584

cc @tmds @dotnet/source-build-internal

@elinor-fung elinor-fung requested a review from dsplaisted August 15, 2023 20:32
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Aug 15, 2023
@mthalman mthalman requested a review from a team August 16, 2023 14:03
@mthalman
Copy link
Member

This needs to be backported to the rc1 branch.

MichaelSimons
MichaelSimons reviewed Aug 16, 2023
View reviewed changes
@mthalman
Copy link
Member

This needs to be backported to the rc1 branch.

This also needs to be backported to the 8.0.1xx branch. The main branch is .NET 9 at this point.

dsplaisted
dsplaisted approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As mentioned, it will need to be backported to 8.0.1xx and 8.0.1xx-rc1.

Once this is merged we should validate that the portable RID graph is correct for a source build.

@elinor-fung elinor-fung merged commit 3780bda into dotnet:main Aug 17, 2023
@elinor-fung elinor-fung deleted the additionalRuntimeIdentifier branch August 17, 2023 03:49
This was referenced Aug 17, 2023
Merged
Merged
@mthalman mthalman mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@mthalman mthalman mthalman approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The non-portable rid needs to be added to the trimmed down rid graph
4 participants
@elinor-fung @mthalman @dsplaisted @MichaelSimons