Skip to content

cherrypick 18355 #18367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

cherrypick 18355 #18367

merged 2 commits into from
Mar 13, 2025

Conversation

KevinRansom
Copy link
Contributor

Bring the dev17.3 fix to revert AttributeEnforcement back to main.

#18355

@KevinRansom KevinRansom requested a review from a team as a code owner March 8, 2025 02:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2025 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@KevinRansom
revert attributes feature (dotnet#18355)
caebd5e 
* revert attributes

* release notes
@KevinRansom KevinRansom added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Mar 8, 2025
T-Gro
T-Gro approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not get why the 9.0.202.md file is added here though.

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Mar 10, 2025
@KevinRansom KevinRansom merged commit d21aa8a into dotnet:main Mar 13, 2025
33 of 34 checks passed
@edgarfgp
Copy link
Contributor

Not sure it matters at this point. But part of me is very disappointed that a year worth of effort would be lost and potentially won’t be ever finished.

@T-Gro
Copy link
Member

T-Gro commented Mar 14, 2025

Not sure it matters at this point. But part of me is very disappointed that a year worth of effort would be lost and potentially won’t be ever finished.

Let's catch up on this, Edgar.
I also do not like having a feature sitting in LanguageFeature.Preview section, I would rather have a path for safe enablement than can also expose us to real world testing.

I think a error -> warning move could satisfy all conditions and provide us with good testing data.
But I want to lean on your expertise on how this could be done while respecting the diagnostics that already existed before.

Please let me know what you think about his.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonie abonie abonie approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KevinRansom @edgarfgp @T-Gro @abonie