revert attributes feature #18355
revert attributes feature #18355
Conversation
❗ Release notes required
|
There was a problem hiding this comment.
It is sad to see this been reverted, as this bring back some legit issues where attribute targets incorrectly used specially in values and functions.
Knowing the history of previous preview features not been completed for many years. I would suggest completely removing this feature and rely in the old incorrect behaviour that everyone is relying on.
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
|
@edgarfgp --- there is some interesting and good refactoring that happened in the PRs associated with this feature. We should be able to salvage some parts of it. There really is only one preview feature that has remained dormant, the slicing PR, because it was a good feature that we never quite got around to finishing. Also for servicing, a minimum change PR is pretty much a requirement. Thanks Kevin |
* revert attributes * release notes
* cherrypick 18355 * revert attributes feature (#18355) * revert attributes * release notes
Revert EnforceAttributeTargets to preview.
There were some libraries that relied on a relaxed enforcement of attribute targets, particularly on Union types. This caused F# 9.0 the apps that relied on these libraries.
In order to reduce the number of times we have to fix bugs related to this, we will reset the feature back to preview mode. Allowing us to re-evaluate how we want this to work in the future, we can re-enable the feature when we have a better unsderstood design.
Update, fsharp.core and fsharp.compiler service package version numbers.
/cc @baronfel /cc @T-Gro