Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FSharpProjectOptions from Transparent Compiler check results #18205

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Remove FSharpProjectOptions from Transparent Compiler check results #18205

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6edaa17
Remove FSharpProjectOptions from Transparent Compiler check results
0101 Jan 6, 2025
e2012d1
f
0101 Jan 6, 2025
6a910a1
Merge remote-tracking branch 'upstream/main' into remove-options-from…
0101 Jan 20, 2025
4af3243
Clarification in exception message, release notes
0101 Jan 20, 2025
a823fa3
f
0101 Jan 20, 2025
4d7705f
Merge branch 'main' into remove-options-from-tc-results
0101 Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarification in exception message, release notes
  • Loading branch information
@0101
0101 committed Jan 20, 2025
commit 4af3243d162a6d5c35f149b629a022634367aac4
1 change: 1 addition & 0 deletions docs/release-notes/.FSharp.Compiler.Service/9.0.300.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

### Changed

* FSharpCheckFileResults.ProjectContext.ProjectOptions will not be available when using the experimental Transparent Compiler feature.

### Breaking Changes

3 changes: 2 additions & 1 deletion src/Compiler/Service/FSharpCheckerResults.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3305,8 +3305,9 @@ module internal ParseAndCheckFile =
type FSharpProjectContext
(thisCcu: CcuThunk, assemblies: FSharpAssembly list, ad: AccessorDomain, projectOptions: FSharpProjectOptions option) =

// TODO: Once API around Transparent Compiler is stabilized we should probably remove this.
member _.ProjectOptions =
projectOptions |> Option.defaultWith (fun () -> failwith "not available")
projectOptions |> Option.defaultWith (fun () -> failwith "ProjectOptions are not available. This is expected when using FSharpChecker with useTransparentCompiler=true.")

member _.GetReferencedAssemblies() = assemblies

Expand Down
Loading