Remove FSharpProjectOptions from Transparent Compiler check results

[0101]

Description

Proper fix for #16979

FSharpProjectOptions is part of the public API, however it might be ok to not have it if you use the new experimental API which relies on snapshots instead. We could also add FSharpProjectSnapshot to the ProjectContext. But the user has to have it in order to request the result, so maybe we can just leave it up to them to hold it if they need it later...

Checklist

• Test cases added
• Performance benchmarks added in case of performance changes
• Release notes entry updated

[github-actions]

❗ Release notes required

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

[T-Gro]

This change only affects internal APIs, right?

[0101]

This change only affects internal APIs, right?

No. With this change, if you use Transparent Compiler to get FSharpCheckFileResults and then you do .ProjectContext.ProjectOptions you'll get an exception.

But if you use the default BackgroundCompiler it keeps working as before.

I think this is ok, since TC is marked as experimental.

But eventually we should probably change the public API. Not sure what the point of options being accessible there is anyway.

[0101]

Another thing is that currently it might already be possible to get an exception requesting ProjectContext under some circumstances:

fsharp/src/Compiler/Service/FSharpCheckerResults.fs

Lines 3453 to 3456 in 73b8cbb

	member _.ProjectContext =
	match details with
	| None -> failwith "not available"
	| Some(scope, _builderOpt) ->

[0101]

I added a better message in the exception in case some one does run into it.

I think we can merge it. It should provide a small perf improvement for Transparent Compiler users since we don't have to construct the options at all.

[psfinaki]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[0101]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).