Skip to content

Make tooltips work in VS in file with no solution #17054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Make tooltips work in VS in file with no solution #17054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd143f6
Don't throw when getting tooltip in VS with no sln
brianrourkeboll Apr 16, 2024
2abc12e
Update release notes
brianrourkeboll Apr 16, 2024
efb3702
Merge branch 'main' into no-throw-if-no-sln
psfinaki Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/release-notes/.VisualStudio/17.11.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Fixed

* Make tooltips work in file with no solution. ([PR #17054](https://github.com/dotnet/fsharp/pull/17054))
3 changes: 2 additions & 1 deletion vsintegration/src/FSharp.Editor/QuickInfo/QuickInfoProvider.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ type internal FSharpAsyncQuickInfoSource

[
Path.GetRelativePath(projectDir, filePath)
Path.GetRelativePath(solutionDir, filePath)
if not (isNull solutionDir) then
Path.GetRelativePath(solutionDir, filePath)
]
|> List.minBy String.length

Expand Down