Make tooltips work in VS in file with no solution #17054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previously, if you opened Visual Studio with no solution and then opened an F# script file, tooltips would not work. This was because the quick info provider did not account for the possibility of a non-existent solution. This change updates the quick info provider so that it no longer tries to get the relative path of a solution that does not exist.
❗ Release notes required
|
brianrourkeboll
changed the title
psfinaki
approved these changes
Apr 16, 2024
T-Gro
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before
no_sln.mp4
After
no_sln_no_throw.mp4
Checklist
Test cases added.
The tests in
QuickInfoProviderTestsonly testTryGetTooltip:fsharp/vsintegration/tests/FSharp.Editor.Tests/QuickInfoProviderTests.fs
Line 100 in f6ae54b
There are no tests that test
FSharpAsyncQuickInfoSource's implementation ofGetQuickInfoItemAsync, which calls the privategetQuickInfoItemfunction, which is where the bug was.It would be nice if such tests existed, but I am not sure how willing I am to spend the time to figure out how to wire everything up for them so that I can test this particular bug.
Release notes entry updated.