Include diagnostics in base line for SyntaxTreeTests. #14986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
approved these changes
Mar 28, 2023
Member
auduchinok
left a comment
auduchinok
left a comment
There was a problem hiding this comment.
@nojaf It's really cool, thanks! It'll be much easier to review error recovery now
nojaf
force-pushed
the
included-diagnostics-parser-tests
branch
from
68baceb to
a67ba56
Compare
vzarytovskii
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this comment it would be interesting to have the diagnostics as well in the baseline files.
I did tweak a couple of source files as they were reporting diagnostics that were never indented.