Add parser recovery for incomplete named pat pair. #14985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
approved these changes
Mar 28, 2023
Member
There was a problem hiding this comment.
@nojaf Would it be hard to add syntax errors dumps into the syntax tree baseline files (in a separate PR, perhaps)? It would be really nice to see what errors are produced from recovery rules or how existing errors change.
Contributor
Author
|
@auduchinok that should be doable, I'll look into it later this week in another PR. |
auduchinok
approved these changes
Mar 28, 2023
edgarfgp
approved these changes
Mar 28, 2023
nojaf
force-pushed
the
named-pair-recovery
branch
from
ce6e39a to
02309b5
Compare
abonie
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first attempt at adding recovery for incomplete named pat pairs.