Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few logging fixes before the new code generator comes in. #4232

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Few logging fixes before the new code generator comes in. #4232

merged 3 commits into from
Aug 1, 2023

Commits on Aug 1, 2023

  1. Few logging fixes before the new code generator comes in. 

    - Implement IEnrichmentPropertyBag on LoggerMessageState to allow more
efficient use in the HttpClient logging paths.

- Fix handling of redaction of null values in the extended logger.
It was returning "" instead of null in that case.

- Add a few utility functions to LoggerMessageState to make code gen
nicer.

- Fix missing _ separator in the implementation of ILogPropertyCollector
in LoggerMessageState.
    Martin Taillefer committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    6560589 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @xakep139
    xakep139 authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    f8a7a93 View commit details
    Browse the repository at this point in the history

  3. Address PR feedback

    Martin Taillefer committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ff753d1 View commit details
    Browse the repository at this point in the history