Few logging fixes before the new code generator comes in. #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement IEnrichmentPropertyBag on LoggerMessageState to allow more efficient use in the HttpClient logging paths. - Fix handling of redaction of null values in the extended logger. It was returning "" instead of null in that case. - Add a few utility functions to LoggerMessageState to make code gen nicer. - Fix missing _ separator in the implementation of ILogPropertyCollector in LoggerMessageState.
ghost
assigned 
xakep139
reviewed
Aug 1, 2023
...rosoft.Extensions.Telemetry.Abstractions/Logging/LoggerMessageState.EnrichmentPropertyBag.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Aug 1, 2023
...rosoft.Extensions.Telemetry.Abstractions/Logging/LoggerMessageState.EnrichmentPropertyBag.cs
Show resolved
Hide resolved
xakep139
reviewed
Aug 1, 2023
...rosoft.Extensions.Telemetry.Abstractions/Logging/LoggerMessageState.EnrichmentPropertyBag.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Aug 1, 2023
.../Microsoft.Extensions.Telemetry.Abstractions/Logging/LoggerMessageState.PropertyCollector.cs
Outdated
Show resolved
Hide resolved
xakep139
reviewed
Aug 1, 2023
...rosoft.Extensions.Telemetry.Abstractions/Logging/LoggerMessageState.EnrichmentPropertyBag.cs
Outdated
Show resolved
Hide resolved
xakep139
approved these changes
Aug 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement IEnrichmentPropertyBag on LoggerMessageState to allow more efficient use in the HttpClient logging paths.
Fix handling of redaction of null values in the extended logger. It was returning "" instead of null in that case.
Add a few utility functions to LoggerMessageState to make code gen nicer.
Fix missing _ separator in the implementation of ILogPropertyCollector in LoggerMessageState.
Microsoft Reviewers: Open in CodeFlow